From: Greg KH <greg@kroah.com>
To: Edward Liaw <edliaw@google.com>
Cc: stable@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
kernel-team@android.com, Mark Brown <broonie@kernel.org>,
Kees Cook <keescook@chromium.org>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 6.6.y] kselftest: Add a ksft_perror() helper
Date: Thu, 23 May 2024 13:28:12 +0200 [thread overview]
Message-ID: <2024052305-unmapped-renewably-b3fc@gregkh> (raw)
In-Reply-To: <20240520175629.162697-1-edliaw@google.com>
On Mon, May 20, 2024 at 05:56:28PM +0000, Edward Liaw wrote:
> From: Mark Brown <broonie@kernel.org>
>
> [ Upstream commit 907f33028871fa7c9a3db1efd467b78ef82cce20 ]
>
> The standard library perror() function provides a convenient way to print
> an error message based on the current errno but this doesn't play nicely
> with KTAP output. Provide a helper which does an equivalent thing in a KTAP
> compatible format.
>
> nolibc doesn't have a strerror() and adding the table of strings required
> doesn't seem like a good fit for what it's trying to do so when we're using
> that only print the errno.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> Stable-dep-of: 071af0c9e582 ("selftests: timers: Convert posix_timers test to generate KTAP output")
> Signed-off-by: Edward Liaw <edliaw@google.com>
> ---
> tools/testing/selftests/kselftest.h | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2024-05-23 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 17:56 [PATCH RESEND 6.6.y] kselftest: Add a ksft_perror() helper Edward Liaw
2024-05-23 11:28 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024052305-unmapped-renewably-b3fc@gregkh \
--to=greg@kroah.com \
--cc=broonie@kernel.org \
--cc=edliaw@google.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox