From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C70013A897; Thu, 23 May 2024 13:16:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716470217; cv=none; b=ZKEUoeaYU4ONmZyV1B5anmEZrxi+mKI6CzhF8sdZliNjABmZ9HAZdJitljxf+uVZhFOKbI7d2yhpKZ7hGr7//TdvK41+xlyZon4M1Od0/O3GRNeJYP7qahopgT8TFMnpeRdOHDSXB7AjIIflV9G9sGVZGDqwbfQkTniZbZT900M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716470217; c=relaxed/simple; bh=hDRFyw2/RhvsJ8SbmqdxvJpmUgaPkBsm3kH5HDJAzRU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=q8Cp4er6pgXlIgLCXNd8pFXwUeM5NzoVfuJqKKWmniY1XSFNXWkCkqa4LE9HW8De/HTFadfvtfwDb0dQMtLvlBc4GY286ohe7T/YseDj5a/upOGrj8kOnWksQ54a/ZUCJ7Wht4HoA23x4gMEgeidhvYeBrL2GeltETjro5Vl2EA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gUWyBKEM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gUWyBKEM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C598C3277B; Thu, 23 May 2024 13:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716470216; bh=hDRFyw2/RhvsJ8SbmqdxvJpmUgaPkBsm3kH5HDJAzRU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gUWyBKEMfHuYvDsMs8xfIuTsn08fPkfbRRv2wav79z9a91FCL5qSG5nXsjQidhGvA VJLeZGzl+zICnkRRLsYsfd1FCnN2NAkto0AjohBGU0RYiaDXgaJLtFPPBA5hbBoGGZ SNA4L/qHkLeryggXioMYHoG8YP6rFdzOY108WqSY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Carlos Llamas , Alice Ryhl Subject: [PATCH 6.9 10/25] binder: fix max_thread type inconsistency Date: Thu, 23 May 2024 15:12:55 +0200 Message-ID: <20240523130330.775904839@linuxfoundation.org> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240523130330.386580714@linuxfoundation.org> References: <20240523130330.386580714@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Carlos Llamas commit 42316941335644a98335f209daafa4c122f28983 upstream. The type defined for the BINDER_SET_MAX_THREADS ioctl was changed from size_t to __u32 in order to avoid incompatibility issues between 32 and 64-bit kernels. However, the internal types used to copy from user and store the value were never updated. Use u32 to fix the inconsistency. Fixes: a9350fc859ae ("staging: android: binder: fix BINDER_SET_MAX_THREADS declaration") Reported-by: Arve Hjønnevåg Cc: stable@vger.kernel.org Signed-off-by: Carlos Llamas Reviewed-by: Alice Ryhl Link: https://lore.kernel.org/r/20240421173750.3117808-1-cmllamas@google.com Signed-off-by: Greg Kroah-Hartman --- drivers/android/binder.c | 2 +- drivers/android/binder_internal.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -5367,7 +5367,7 @@ static long binder_ioctl(struct file *fi goto err; break; case BINDER_SET_MAX_THREADS: { - int max_threads; + u32 max_threads; if (copy_from_user(&max_threads, ubuf, sizeof(max_threads))) { --- a/drivers/android/binder_internal.h +++ b/drivers/android/binder_internal.h @@ -421,7 +421,7 @@ struct binder_proc { struct list_head todo; struct binder_stats stats; struct list_head delivered_death; - int max_threads; + u32 max_threads; int requested_threads; int requested_threads_started; int tmp_ref;