From: Greg KH <greg@kroah.com>
To: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org,
linux-sound@vger.kernel.org,
pierre-louis.bossart@linux.intel.com,
kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.intel.com,
stable@vger.kernel.org, yung-chuan.liao@linux.intel.com
Subject: Re: [PATCH stable-6.9.y] ASoC: Intel: sof_sdw: use generic rtd_init function for Realtek SDW DMICs
Date: Thu, 23 May 2024 14:02:53 +0200 [thread overview]
Message-ID: <2024052345-manhood-overrate-6b7d@gregkh> (raw)
In-Reply-To: <20240521072451.5488-1-peter.ujfalusi@linux.intel.com>
On Tue, May 21, 2024 at 10:24:51AM +0300, Peter Ujfalusi wrote:
> From: Bard Liao <yung-chuan.liao@linux.intel.com>
>
> commit bee2fe44679f1e6a5332d7f78587ccca4109919f upstream.
>
> The only thing that the rt_xxx_rtd_init() functions do is to set
> card->components. And we can set card->components with name_prefix
> as rt712_sdca_dmic_rtd_init() does.
> And sof_sdw_rtd_init() will always select the first dai with the
> given dai->name from codec_info_list[]. Unfortunately, we have
> different codecs with the same dai name. For example, dai name of
> rt715 and rt715-sdca are both "rt715-aif2". Using a generic rtd_init
> allow sof_sdw_rtd_init() run the rtd_init() callback from a similar
> codec dai.
>
> Fixes: 8266c73126b7 ("ASoC: Intel: sof_sdw: add common sdw dai link init")
> Reviewed-by: Chao Song <chao.song@linux.intel.com>
> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Link: https://msgid.link/r/20240326160429.13560-25-pierre-louis.bossart@linux.intel.com
> Link: https://github.com/thesofproject/linux/issues/4999 # 6.9.y stable report
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Cc: stable@vger.kernel.org # 6.9
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> ---
> Hi,
>
> Regression reported in 6.9 by a user:
> https://github.com/thesofproject/linux/issues/4999
>
> The fix for the issue somehow dodged the 6.9 cycle and only landed mainline
> for 6.10, before -rc1 tag.
>
> Our trust in machines shaken a bit, so just to make sure that this patch is
> picked for stable 6.9, I have cherry-picked it and tested on a device that
> it is working without any side-effect.
Now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2024-05-23 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 7:24 [PATCH stable-6.9.y] ASoC: Intel: sof_sdw: use generic rtd_init function for Realtek SDW DMICs Peter Ujfalusi
2024-05-23 12:02 ` Greg KH [this message]
2024-05-23 12:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024052345-manhood-overrate-6b7d@gregkh \
--to=greg@kroah.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox