From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A73B1DFED; Mon, 27 May 2024 19:05:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716836730; cv=none; b=ojsSk/bjvbY0vVwhWxC532C7mXZ8Eenh6umpzZUug8JS3gibZRkzVTt4L6stHcPF8eJ1U40DHSxXp4PYMRe7B706sgmPLEIAbWHs330G6wT/I5reVB6+LhzVZ+j+jcF6Bxkx0ffOWmF7QOHzuITLN/xWrnE1UsTLhwzuTdhrMCo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716836730; c=relaxed/simple; bh=rNKid9Aw+HKHjpAM7kiqXg8WQyMrIt4xlulIhrAwAVQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xdm/Wu4obLWbLSdUzb8BY2JHw2WyT29rnOF29YEspfFMG35Zb5xaI25SJltKVmbyKmYr+/8N8wcKRPLhLCQvZ33NLjWfcY0pvUKnT4EUxarAsy1t18fMQ1ayo5hLr6YYsto3pLo37a4hyzjyBeEBpGDl+meMzhgf7Wx0fFpC1PI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1xEHLoER; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1xEHLoER" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2BD9C2BBFC; Mon, 27 May 2024 19:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716836730; bh=rNKid9Aw+HKHjpAM7kiqXg8WQyMrIt4xlulIhrAwAVQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1xEHLoERQ9wqx/Nh09GPLqndw6SD9T7wB6vjEaq44qj/wmKVA9pLdwUT5Z8Ym3Oez 5HMndS0MdAMnSYDpUv/XrDR7jnrxuLePKKDq71cTH8ccGWij9QDYz2iiALF/5In0s0 X9I1stUy0V/yIbKlnAsN+uRrCgwyWEkw8ZuhiloM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zenghui Yu , Thomas Gleixner , Jiaxun Yang , Sasha Levin Subject: [PATCH 6.9 138/427] irqchip/loongson-pch-msi: Fix off-by-one on allocation error path Date: Mon, 27 May 2024 20:53:05 +0200 Message-ID: <20240527185614.772067607@linuxfoundation.org> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240527185601.713589927@linuxfoundation.org> References: <20240527185601.713589927@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zenghui Yu [ Upstream commit b327708798809328f21da8dc14cc8883d1e8a4b3 ] When pch_msi_parent_domain_alloc() returns an error, there is an off-by-one in the number of interrupts to be freed. Fix it by passing the number of successfully allocated interrupts, instead of the relative index of the last allocated one. Fixes: 632dcc2c75ef ("irqchip: Add Loongson PCH MSI controller") Signed-off-by: Zenghui Yu Signed-off-by: Thomas Gleixner Reviewed-by: Jiaxun Yang Link: https://lore.kernel.org/r/20240327142334.1098-1-yuzenghui@huawei.com Signed-off-by: Sasha Levin --- drivers/irqchip/irq-loongson-pch-msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-loongson-pch-msi.c b/drivers/irqchip/irq-loongson-pch-msi.c index 6e1e1f011bb29..dd4d699170f4e 100644 --- a/drivers/irqchip/irq-loongson-pch-msi.c +++ b/drivers/irqchip/irq-loongson-pch-msi.c @@ -136,7 +136,7 @@ static int pch_msi_middle_domain_alloc(struct irq_domain *domain, err_hwirq: pch_msi_free_hwirq(priv, hwirq, nr_irqs); - irq_domain_free_irqs_parent(domain, virq, i - 1); + irq_domain_free_irqs_parent(domain, virq, i); return err; } -- 2.43.0