From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C7E815FCFC; Mon, 27 May 2024 19:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716837853; cv=none; b=WVKyyB4bp8YywS722JwiC/kmt7lX+LX8MnzOu8IKddPUuNWzFWQep0VqkLNn6dT37kPaj0jP9CkRthO1+WZ7qilrpLgtsp8ccUadn9zDclPuyrqQGaxDfyTDoah1DWiZyZhYReq2lH/KCfgPdAfbS5oRogJMlOLhXUmx/gwbifU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716837853; c=relaxed/simple; bh=9GMZeknBZnZRoQWriG0demUMh1PZNX4Ll4jc+Yq5ies=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QZDPA51lXJsuJlmulbBcJ2OmMZKzaR51QfzHCHWcqFVIINopt/y/wFEJQVpRAwcf7cgggMffQoW7kxSJnP2ftipx8/IUIWBda2/CLcqF1o2CdCm1wzxUpPDr3b9NKmPaC+TebrbGtICOpish6Q0tMwoNgKZmIIuCBHeq+Es6oso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ApZ0lSpt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ApZ0lSpt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B3CCC32781; Mon, 27 May 2024 19:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716837852; bh=9GMZeknBZnZRoQWriG0demUMh1PZNX4Ll4jc+Yq5ies=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ApZ0lSptaba7tyYF3EQbN349KTxzsLddaHl4SQ/12kb7Efhb8h1JEa/5MvGWiYru8 y/DFm8qwCtfuk/3t7P1AOmJ7JoOrcKpU5q/alf8zYYw6brqZvW3pBefSK2jgUd9Eqs 4sf+dyNBxsZef+/JfDpmB9LMSU70CMNep9KirJuM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guixiong Wei , Ingo Molnar , Kees Cook , Sasha Levin Subject: [PATCH 6.8 168/493] x86/boot: Ignore relocations in .notes sections in walk_relocs() too Date: Mon, 27 May 2024 20:52:50 +0200 Message-ID: <20240527185635.854889864@linuxfoundation.org> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240527185626.546110716@linuxfoundation.org> References: <20240527185626.546110716@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.8-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guixiong Wei [ Upstream commit 76e9762d66373354b45c33b60e9a53ef2a3c5ff2 ] Commit: aaa8736370db ("x86, relocs: Ignore relocations in .notes section") ... only started ignoring the .notes sections in print_absolute_relocs(), but the same logic should also by applied in walk_relocs() to avoid such relocations. [ mingo: Fixed various typos in the changelog, removed extra curly braces from the code. ] Fixes: aaa8736370db ("x86, relocs: Ignore relocations in .notes section") Fixes: 5ead97c84fa7 ("xen: Core Xen implementation") Fixes: da1a679cde9b ("Add /sys/kernel/notes") Signed-off-by: Guixiong Wei Signed-off-by: Ingo Molnar Reviewed-by: Kees Cook Link: https://lore.kernel.org/r/20240317150547.24910-1-weiguixiong@bytedance.com Signed-off-by: Sasha Levin --- arch/x86/tools/relocs.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c index b029fb81ebeee..e7a44a7f617fb 100644 --- a/arch/x86/tools/relocs.c +++ b/arch/x86/tools/relocs.c @@ -746,6 +746,15 @@ static void walk_relocs(int (*process)(struct section *sec, Elf_Rel *rel, if (!(sec_applies->shdr.sh_flags & SHF_ALLOC)) { continue; } + + /* + * Do not perform relocations in .notes sections; any + * values there are meant for pre-boot consumption (e.g. + * startup_xen). + */ + if (sec_applies->shdr.sh_type == SHT_NOTE) + continue; + sh_symtab = sec_symtab->symtab; sym_strtab = sec_symtab->link->strtab; for (j = 0; j < sec->shdr.sh_size/sizeof(Elf_Rel); j++) { -- 2.43.0