From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFEF6168C4; Mon, 27 May 2024 19:26:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716837980; cv=none; b=L8rL9tyFqqQVCiAdVkhf1dYSRVkvhr8oXjwHFvMjeQIU2idcjSQffaPdKy58fVXAttXA9SJ6EZ2XXl40XKXHv/16o0vj4UoQzGypSzlKtY1kUTMNarxnJgINDW8zIKYckFHSdioc9wNUNHzRmTdPAVPX+O266hTO2MAeYlenHDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716837980; c=relaxed/simple; bh=HSxCYTHfA9hNbDF9rZyrT02vjVrw1MUrsQ3btPnxZzE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gW4owdfLxTpEqZ7UQOPyARHGBlaJw8652NbSeV6S1ffKsfZ7FzDBRo3xAFCCyuonOAoOsQ8norx5KFvyFio4Me742R5jvZeMXqx+uwtqpHBtp9CoHcMs64pE6ALrAVs97UVY6NpX89MDGtTJopqlEFwRQNpkv01BF995aupjPvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=X6jKzLc0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="X6jKzLc0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64267C2BBFC; Mon, 27 May 2024 19:26:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716837980; bh=HSxCYTHfA9hNbDF9rZyrT02vjVrw1MUrsQ3btPnxZzE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X6jKzLc02gwgLJPVOi1po34pkgRs6c6f+1XjWAd8DEOxO6LWTq1PDO3VEzYy3Jcun U6Y5/qdrG/udZh5f30bnkYrvmWeJfFcyCySzpG70eBNMKPsoSNHJc3xqIXRhZXMe/j QTEWcB1FOcaw9p79hd9YxkuYFD1lgMMA5ElLAkEM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Daniel Gabay , Miriam Rachel Korenblit , Johannes Berg , Sasha Levin Subject: [PATCH 6.8 177/493] wifi: iwlwifi: mvm: fix check in iwl_mvm_sta_fw_id_mask Date: Mon, 27 May 2024 20:52:59 +0200 Message-ID: <20240527185636.138850616@linuxfoundation.org> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240527185626.546110716@linuxfoundation.org> References: <20240527185626.546110716@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.8-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johannes Berg [ Upstream commit d69aef8084cc72df7b0f2583096d9b037c647ec8 ] In the previous commit, I renamed the variable to differentiate mac80211/mvm link STA, but forgot to adjust the check. The one from mac80211 is already non-NULL anyway, but the mvm one can be NULL when the mac80211 isn't during link switch conditions. Fix the check. Fixes: 2783ab506eaa ("wifi: iwlwifi: mvm: select STA mask only for active links") Reviewed-by: Daniel Gabay Reviewed-by: Miriam Rachel Korenblit Link: https://msgid.link/20240325180850.e95b442bafe9.I8c0119fce7b00cb4f65782930d2c167ed5dd0a6e@changeid Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c index dffdd00f8ab62..36dc291d98dd6 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c @@ -36,7 +36,7 @@ u32 iwl_mvm_sta_fw_id_mask(struct iwl_mvm *mvm, struct ieee80211_sta *sta, mvm_link_sta = rcu_dereference_check(mvmsta->link[link_id], lockdep_is_held(&mvm->mutex)); - if (!link_sta) + if (!mvm_link_sta) continue; result |= BIT(mvm_link_sta->sta_id); -- 2.43.0