From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DCB215FCFB; Mon, 27 May 2024 19:36:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716838593; cv=none; b=ImxeH9y/yQ2bg+3JRPvahBInnDNybgMW3jYvfQ1lZvN3l8iYNyEvqQQ4+xw/uwZ9+CJSyGR6+GJEqflj67VB6A94mt+GcUFUZRu0kn9qrL4FuewxNytgFCvvdTaT5iG0G9prt5KlARgAy8BhMnN9gmXPllzXQR4ZuWtD5CrO8fE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716838593; c=relaxed/simple; bh=Az1+j/pC+vu41qCT8WSZ+S2tq9GVqXPsujkHgIkq/08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TZXCDDH0DFEIv8eXVCmzHdePjRPuh/ykPwMDqCMCtSTd3IXfQEB30FJ4lJQE8K/fiGCKYBtpAl2fdkSr7HxKrG2/NsiMp++iVLqoDrgEHe6/uEvqDUEMGP2i0R3vai9snhIIGUli89cBa0kpMzI9f7m8e9EBsNLkWv/KHwXQ/ZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1PwnGNL2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1PwnGNL2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20E90C2BBFC; Mon, 27 May 2024 19:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716838593; bh=Az1+j/pC+vu41qCT8WSZ+S2tq9GVqXPsujkHgIkq/08=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1PwnGNL2FcV6CGY++aN2Aoh/i3cVmIow4d8b1AQPBg9kh/ZCNyl7la1Ap2+aFumaJ RBaSro9f+5J8WlIg+yHJ9zbFUurGAvEMpXC5XzG+4Xl62XfukzfwwmhZ7Zh+YbObiI aLrIBGqr4Ja1r0YcIqN3/RLo8DZUfvgZGHwdm180= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Christoph Hellwig , David Hildenbrand , Andy Lutomirski , Dave Hansen , Fei Li , Peter Zijlstra , Ingo Molnar , Andrew Morton , Sasha Levin Subject: [PATCH 6.8 454/493] virt: acrn: stop using follow_pfn Date: Mon, 27 May 2024 20:57:36 +0200 Message-ID: <20240527185645.066574811@linuxfoundation.org> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240527185626.546110716@linuxfoundation.org> References: <20240527185626.546110716@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.8-stable review patch. If anyone has any objections, please let me know. ------------------ From: Christoph Hellwig [ Upstream commit 1b265da7ea1e1ae997fa119c2846bb389eb39c6b ] Patch series "remove follow_pfn". This series open codes follow_pfn in the only remaining caller, although the code there remains questionable. It then also moves follow_phys into the only user and simplifies it a bit. This patch (of 3): Switch from follow_pfn to follow_pte so that we can get rid of follow_pfn. Note that this doesn't fix any of the pre-existing raciness and lack of permission checking in the code. Link: https://lkml.kernel.org/r/20240324234542.2038726-1-hch@lst.de Link: https://lkml.kernel.org/r/20240324234542.2038726-2-hch@lst.de Signed-off-by: Christoph Hellwig Reviewed-by: David Hildenbrand Cc: Andy Lutomirski Cc: Dave Hansen Cc: Fei Li Cc: Peter Zijlstra Cc: Ingo Molnar Signed-off-by: Andrew Morton Stable-dep-of: 3d6586008f7b ("drivers/virt/acrn: fix PFNMAP PTE checks in acrn_vm_ram_map()") Signed-off-by: Sasha Levin --- drivers/virt/acrn/mm.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/virt/acrn/mm.c b/drivers/virt/acrn/mm.c index fa5d9ca6be570..69c3f619f8819 100644 --- a/drivers/virt/acrn/mm.c +++ b/drivers/virt/acrn/mm.c @@ -171,18 +171,24 @@ int acrn_vm_ram_map(struct acrn_vm *vm, struct acrn_vm_memmap *memmap) mmap_read_lock(current->mm); vma = vma_lookup(current->mm, memmap->vma_base); if (vma && ((vma->vm_flags & VM_PFNMAP) != 0)) { + spinlock_t *ptl; + pte_t *ptep; + if ((memmap->vma_base + memmap->len) > vma->vm_end) { mmap_read_unlock(current->mm); return -EINVAL; } - ret = follow_pfn(vma, memmap->vma_base, &pfn); - mmap_read_unlock(current->mm); + ret = follow_pte(vma->vm_mm, memmap->vma_base, &ptep, &ptl); if (ret < 0) { + mmap_read_unlock(current->mm); dev_dbg(acrn_dev.this_device, "Failed to lookup PFN at VMA:%pK.\n", (void *)memmap->vma_base); return ret; } + pfn = pte_pfn(ptep_get(ptep)); + pte_unmap_unlock(ptep, ptl); + mmap_read_unlock(current->mm); return acrn_mm_region_add(vm, memmap->user_vm_pa, PFN_PHYS(pfn), memmap->len, -- 2.43.0