From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62D551D009F; Wed, 5 Jun 2024 12:05:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717589150; cv=none; b=X+miEZ/pIM5czP0SOuNXe8Wm0pDljGGD7JwlqNF21nJoig2SUtycbVVsakSMQgghVYnB9qycrCJSp9f9R/haOk0EQJ8KYN+gFfwF+q0qprlJC9gLoulXOjlamT5vJ2FupqoJOAx7Z78lKlvhYxuv/fAAD9LiGMgoDigmOK1d22c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717589150; c=relaxed/simple; bh=o2S4bVhDNJ+1ziiBZQeF7Y+3Bej05M4AnuKFqi8+NmQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UAWTqMbWcPPBNIurtcGaHlVQqzOoZxcsaA4zZ75E0NNFjmasN/MoaW5RbiExJNyXuoC1N5fkKvWpe2MsPsH9DQyBwhudaFlqI62DlKuGaOrDW2SbQfzCKwbaz81D2xbKaY6x7Om4gZjcpve5HzaXQir/uhhPr5Op8BtPjf8unqs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LOyTKfzq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LOyTKfzq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33160C3277B; Wed, 5 Jun 2024 12:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717589150; bh=o2S4bVhDNJ+1ziiBZQeF7Y+3Bej05M4AnuKFqi8+NmQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LOyTKfzq/8D9+WyxsAlF1U9vcojnnmDvkM4wNB3HPmwOmtzN5GndHigBGFCsXBZQz n5Mg0pvD26MAnB/FqQ9tLsT3ncTEXKQudjPOiJ+73KeuwzyPSEZ6bhda0p2419CINt bnDWM5cqtAAqXCXSJlZQ8GqR2/OYrcirxxUmRH54i46MyNurZdObs6oxlXS9UT27Mi 5flfKIebFxcUrYTuqTHd6tOpWHg9964UcBUR45/gXHqpCEVaNNUnuc2ShhIyTCwpvF OjCLI8guEtNaRIR/He+aljjruWV6EPyRRl14PyMW0TVFpnuCZ7aLKrqDfnqoBrvGL4 Ui/o4NIUaUfxQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Bart Van Assche , Jens Axboe , Sasha Levin , martin.petersen@oracle.com, hare@suse.de, linux-block@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 12/12] null_blk: Do not allow runt zone with zone capacity smaller then zone size Date: Wed, 5 Jun 2024 08:05:22 -0400 Message-ID: <20240605120528.2967750-12-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240605120528.2967750-1-sashal@kernel.org> References: <20240605120528.2967750-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.160 Content-Transfer-Encoding: 8bit From: Damien Le Moal [ Upstream commit b164316808ec5de391c3e7b0148ec937d32d280d ] A zoned device with a smaller last zone together with a zone capacity smaller than the zone size does make any sense as that does not correspond to any possible setup for a real device: 1) For ZNS and zoned UFS devices, all zones are always the same size. 2) For SMR HDDs, all zones always have the same capacity. In other words, if we have a smaller last runt zone, then this zone capacity should always be equal to the zone size. Add a check in null_init_zoned_dev() to prevent a configuration to have both a smaller zone size and a zone capacity smaller than the zone size. Signed-off-by: Damien Le Moal Reviewed-by: Niklas Cassel Reviewed-by: Bart Van Assche Link: https://lore.kernel.org/r/20240530054035.491497-2-dlemoal@kernel.org Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/null_blk/zoned.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/block/null_blk/zoned.c b/drivers/block/null_blk/zoned.c index dae54dd1aeac3..e0819b04d288f 100644 --- a/drivers/block/null_blk/zoned.c +++ b/drivers/block/null_blk/zoned.c @@ -80,6 +80,17 @@ int null_init_zoned_dev(struct nullb_device *dev, struct request_queue *q) return -EINVAL; } + /* + * If a smaller zone capacity was requested, do not allow a smaller last + * zone at the same time as such zone configuration does not correspond + * to any real zoned device. + */ + if (dev->zone_capacity != dev->zone_size && + dev->size & (dev->zone_size - 1)) { + pr_err("A smaller last zone is not allowed with zone capacity smaller than zone size.\n"); + return -EINVAL; + } + zone_capacity_sects = mb_to_sects(dev->zone_capacity); dev_capacity_sects = mb_to_sects(dev->size); dev->zone_size_sects = mb_to_sects(dev->zone_size); -- 2.43.0