From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA1241A2C31; Thu, 6 Jun 2024 14:13:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717683206; cv=none; b=kMdKQAWMfe/LYCl2bkpcoDsK9E7cHW0yXhINh/LV74N8dpE2vTz6XnZ8rJCLH7w2IqxYa1f6D7fQ40OlkzIn9SXL0V+CmE1DSe6Rxu2ZI38nApy++mRrk6LqOJBbPhMVPoqQvV0Jy4LpSBTWU2Nwe9M9F1iAOcPFSRiTwbjPSY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717683206; c=relaxed/simple; bh=qiVnuhkLvjoBo18J8cHsD11pF7HpYRgL6w3zw57iB9w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gtF0sxKsuyEiZQ7EBXgkJicxA1WBuK0rAEkSCY0gLl7behu2cDbfVPSxJs4q6Xh0fzqDN0W9k+lffZxlcCFWG1zWrpD8EJpuqKFyTnAV7C1pBFJw0uVzcJHzPzy/Vca6Pie9Np3et61HbSuLtWpQeEgyIceejY1lBQMBkJMDuaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1Jbo/kbH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1Jbo/kbH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A15AC2BD10; Thu, 6 Jun 2024 14:13:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1717683206; bh=qiVnuhkLvjoBo18J8cHsD11pF7HpYRgL6w3zw57iB9w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1Jbo/kbHYEobOIzw3nAXpyrO2aUoqP0qZ1QmDC8KHeQb0eZ0gYqlUxMMrzZz9MRaU Irct2wa6080nGFBOyqEUkvm/YlBoFOQ0eXtNRY4xcf9NB25s+Yaq3+3yl2GQNp7wWB 7uCPyUATRNxlpuenpAefmQE0uLEq+/kAMgSk68Eg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chun-Kuang Hu , AngeloGioacchino Del Regno , Sasha Levin Subject: [PATCH 6.1 084/473] soc: mediatek: cmdq: Fix typo of CMDQ_JUMP_RELATIVE Date: Thu, 6 Jun 2024 16:00:13 +0200 Message-ID: <20240606131702.684373312@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240606131659.786180261@linuxfoundation.org> References: <20240606131659.786180261@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chun-Kuang Hu [ Upstream commit ed4d5ab179b9f0a60da87c650a31f1816db9b4b4 ] For cmdq jump command, offset 0 means relative jump and offset 1 means absolute jump. cmdq_pkt_jump() is absolute jump, so fix the typo of CMDQ_JUMP_RELATIVE in cmdq_pkt_jump(). Fixes: 946f1792d3d7 ("soc: mediatek: cmdq: add jump function") Signed-off-by: Chun-Kuang Hu Reviewed-by: AngeloGioacchino Del Regno Link: https://lore.kernel.org/r/20240222154120.16959-2-chunkuang.hu@kernel.org Signed-off-by: AngeloGioacchino Del Regno Signed-off-by: Sasha Levin --- drivers/soc/mediatek/mtk-cmdq-helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c index c1837a4682673..3ed8bd63f7e14 100644 --- a/drivers/soc/mediatek/mtk-cmdq-helper.c +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c @@ -13,7 +13,8 @@ #define CMDQ_POLL_ENABLE_MASK BIT(0) #define CMDQ_EOC_IRQ_EN BIT(0) #define CMDQ_REG_TYPE 1 -#define CMDQ_JUMP_RELATIVE 1 +#define CMDQ_JUMP_RELATIVE 0 +#define CMDQ_JUMP_ABSOLUTE 1 struct cmdq_instruction { union { @@ -396,7 +397,7 @@ int cmdq_pkt_jump(struct cmdq_pkt *pkt, dma_addr_t addr) struct cmdq_instruction inst = {}; inst.op = CMDQ_CODE_JUMP; - inst.offset = CMDQ_JUMP_RELATIVE; + inst.offset = CMDQ_JUMP_ABSOLUTE; inst.value = addr >> cmdq_get_shift_pa(((struct cmdq_client *)pkt->cl)->chan); return cmdq_pkt_append_command(pkt, inst); -- 2.43.0