From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA8E7197A8F; Thu, 6 Jun 2024 14:14:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717683279; cv=none; b=beuNUoidNtJ8vfA4vzx08xx5SkxEvs5/yT99bURiEuV1/HiayWeOWZVOqOL0JzsMg/ynPo0V8oeEvEsFgvUiHw+mynS73QePR9sBWX+W6f5+qk6utjqpG0uTttz0mOXQiw6plWXaeYGb97Aa6e/WGm9bx3PL/wRFH7hrcnpemZ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717683279; c=relaxed/simple; bh=6AsYuOqF+r59VvyVxEonuJJuNEW9VrnMV9vznWPvWM0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oYfIBCfIwPLL+K4tGq5+deArSY6P20JW5qA4hv5ajpVOm2v7ilWdfktupnTi/yNwUXdcK2mtZvHtlTK4hnPTKgbPTj/1BcA1iYyS/tcMaz7zN7uYRheeE6tXSnisYRWTTYU4Jkcxbuj9CKKRD3GS8yp4d5xzlFPB1WCWyqE9ObU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GOjYwGZj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GOjYwGZj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A952BC2BD10; Thu, 6 Jun 2024 14:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1717683279; bh=6AsYuOqF+r59VvyVxEonuJJuNEW9VrnMV9vznWPvWM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GOjYwGZjVn2BDCnYM2yFtwQFYU9tROIjSmWMMOnajuMZsf+Ce6Fl7OA314IiP9GEL ldOGonehCZIY303fXcYTl3fBEmp3v6PcpdcrP7y6xWqidQrAY6FTjsAiz8IGnOwagH 7+Fz2y8RBWY9dmG1wBMgXBjIAQ7XyIU9vTkFWZzs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bui Quang Minh , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 6.1 157/473] scsi: bfa: Ensure the copied buf is NUL terminated Date: Thu, 6 Jun 2024 16:01:26 +0200 Message-ID: <20240606131705.149856501@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240606131659.786180261@linuxfoundation.org> References: <20240606131659.786180261@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bui Quang Minh [ Upstream commit 13d0cecb4626fae67c00c84d3c7851f6b62f7df3 ] Currently, we allocate a nbytes-sized kernel buffer and copy nbytes from userspace to that buffer. Later, we use sscanf on this buffer but we don't ensure that the string is terminated inside the buffer, this can lead to OOB read when using sscanf. Fix this issue by using memdup_user_nul instead of memdup_user. Fixes: 9f30b674759b ("bfa: replace 2 kzalloc/copy_from_user by memdup_user") Signed-off-by: Bui Quang Minh Link: https://lore.kernel.org/r/20240424-fix-oob-read-v2-3-f1f1b53a10f4@gmail.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/bfa/bfad_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/bfa/bfad_debugfs.c b/drivers/scsi/bfa/bfad_debugfs.c index 52db147d9979d..f6dd077d47c9a 100644 --- a/drivers/scsi/bfa/bfad_debugfs.c +++ b/drivers/scsi/bfa/bfad_debugfs.c @@ -250,7 +250,7 @@ bfad_debugfs_write_regrd(struct file *file, const char __user *buf, unsigned long flags; void *kern_buf; - kern_buf = memdup_user(buf, nbytes); + kern_buf = memdup_user_nul(buf, nbytes); if (IS_ERR(kern_buf)) return PTR_ERR(kern_buf); @@ -317,7 +317,7 @@ bfad_debugfs_write_regwr(struct file *file, const char __user *buf, unsigned long flags; void *kern_buf; - kern_buf = memdup_user(buf, nbytes); + kern_buf = memdup_user_nul(buf, nbytes); if (IS_ERR(kern_buf)) return PTR_ERR(kern_buf); -- 2.43.0