From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C589319644C; Thu, 6 Jun 2024 14:15:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717683304; cv=none; b=BZGYzgREaVxLAATH109uGI7kzSsePFRpu/3jAeKnuqeEOqwIMBu8stxTbjIr1W1W5ZtVNNojNIvWhmJC62Oghk0/tiV0px8YNvxNY6AzyKxtSU5W5sy4gW6Bl3/Pc+zSbqJerlOiio5leMraxVHJoOLExybbWQUn1pv5Xu6snoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717683304; c=relaxed/simple; bh=TSxdRAxK4DJsO0Ql3xYCuf+x7bK9ACtpkTWPhW0eBVg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JrY2PlacTn2JR/4wZeBd67GpTh9N3dmdaSMEDCCw0AM6vnKfboMNWdNtdTKdCMs91EUWAo7RsTQyPwQ/ukhkgEMJDm1cNmKJqXLoGzOz2NJtQM8W//f6mApDcByytnV1RZjHfqwl1+d+ejiFuxyZL2Yvijpz7PeYWlZnAs71G3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cKOmu9EP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cKOmu9EP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A50D5C2BD10; Thu, 6 Jun 2024 14:15:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1717683304; bh=TSxdRAxK4DJsO0Ql3xYCuf+x7bK9ACtpkTWPhW0eBVg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cKOmu9EPI0Gtke9yi00IvP2XTDi8d7TC6xUc7G15H3g9B1v7SeMHx3kCPCWvIRLe9 xGOcj2mhoGZllx3ueskBkHppfoyEmC7TZBGFicphuPoiUWf+aoOkRT9yU60Wa2EIFI 6WBGEhwfL1CFKGPGS9flCYyTae4u19e/5pT6vgG0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Paolo Abeni , "Matthieu Baerts (NGI0)" , Mat Martineau , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.1 185/473] mptcp: SO_KEEPALIVE: fix getsockopt support Date: Thu, 6 Jun 2024 16:01:54 +0200 Message-ID: <20240606131706.045985360@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240606131659.786180261@linuxfoundation.org> References: <20240606131659.786180261@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Matthieu Baerts (NGI0) [ Upstream commit a65198136eaa15b74ee0abf73f12ef83d469a334 ] SO_KEEPALIVE support has to be set on each subflow: on each TCP socket, where sk_prot->keepalive is defined. Technically, nothing has to be done on the MPTCP socket. That's why mptcp_sol_socket_sync_intval() was called instead of mptcp_sol_socket_intval(). Except that when nothing is done on the MPTCP socket, the getsockopt(SO_KEEPALIVE), handled in net/core/sock.c:sk_getsockopt(), will not know if SO_KEEPALIVE has been set on the different subflows or not. The fix is simple: simply call mptcp_sol_socket_intval() which will end up calling net/core/sock.c:sk_setsockopt() where the SOCK_KEEPOPEN flag will be set, the one used in sk_getsockopt(). So now, getsockopt(SO_KEEPALIVE) on an MPTCP socket will return the same value as the one previously set with setsockopt(SO_KEEPALIVE). Fixes: 1b3e7ede1365 ("mptcp: setsockopt: handle SO_KEEPALIVE and SO_PRIORITY") Acked-by: Paolo Abeni Signed-off-by: Matthieu Baerts (NGI0) Signed-off-by: Mat Martineau Link: https://lore.kernel.org/r/20240514011335.176158-2-martineau@kernel.org Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/mptcp/sockopt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c index 30374fd44228f..e59e46e07b5c9 100644 --- a/net/mptcp/sockopt.c +++ b/net/mptcp/sockopt.c @@ -179,8 +179,6 @@ static int mptcp_setsockopt_sol_socket_int(struct mptcp_sock *msk, int optname, switch (optname) { case SO_KEEPALIVE: - mptcp_sol_socket_sync_intval(msk, optname, val); - return 0; case SO_DEBUG: case SO_MARK: case SO_PRIORITY: -- 2.43.0