Are the 'FAILED' notifications always sent?

Are the 'FAILED' notifications always sent?

[Matthieu Baerts]

Hi Sasha,

Thank you for the recent backports linked to MPTCP.

Recently, I noticed that two patches [1] [2] with the same "Fixes" tag
-- but without "Cc: stable", sorry for that -- have been backported to
different stable versions. That's good, thank you!

The first patch made its way to v5.15, while the second one went up to
v6.8, but not to older stable versions. I understand it didn't go
further because of other conflicts, and I'm ready to help to fix them.

I just wanted to know if it is normal I didn't get any 'FAILED'
notifications like the ones Greg send [3]: I rely on them to know which
patches have been treated by the Stable team, but had conflicts. Will I
get these notifications later (no hurry), or should I not rely on them
to track fixes that could not be backported?

Cheers,
Matt

[1]
https://lore.kernel.org/mptcp/20240514011335.176158-2-martineau@kernel.org/
[2]
https://lore.kernel.org/mptcp/20240514011335.176158-3-martineau@kernel.org/
[3] 'FAILED: patch "[PATCH] (...)" failed to apply to x.y-stable tree'
-- 
Sponsored by the NGI0 Core fund.

Re: Are the 'FAILED' notifications always sent?

[Greg KH]

On Mon, May 27, 2024 at 12:55:47PM +0200, Matthieu Baerts wrote:
> Hi Sasha,
> 
> Thank you for the recent backports linked to MPTCP.
> 
> Recently, I noticed that two patches [1] [2] with the same "Fixes" tag
> -- but without "Cc: stable", sorry for that -- have been backported to
> different stable versions. That's good, thank you!
> 
> The first patch made its way to v5.15, while the second one went up to
> v6.8, but not to older stable versions. I understand it didn't go
> further because of other conflicts, and I'm ready to help to fix them.
> 
> I just wanted to know if it is normal I didn't get any 'FAILED'
> notifications like the ones Greg send [3]: I rely on them to know which
> patches have been treated by the Stable team, but had conflicts. Will I
> get these notifications later (no hurry), or should I not rely on them
> to track fixes that could not be backported?

FAILED only happens for patches that explicitly have a "Cc: stable@" tag
in a commit.  If you only have a "Fixes:" tag, that doesn't happen as we
read that as "best effort if the stable team wants to add it".

thanks,

greg k-h

Re: Are the 'FAILED' notifications always sent?

[Matthieu Baerts]

Hi Greg,

Thank you for the reply!

On 12/06/2024 14:11, Greg KH wrote:
> On Mon, May 27, 2024 at 12:55:47PM +0200, Matthieu Baerts wrote:
>> Hi Sasha,
>>
>> Thank you for the recent backports linked to MPTCP.
>>
>> Recently, I noticed that two patches [1] [2] with the same "Fixes" tag
>> -- but without "Cc: stable", sorry for that -- have been backported to
>> different stable versions. That's good, thank you!
>>
>> The first patch made its way to v5.15, while the second one went up to
>> v6.8, but not to older stable versions. I understand it didn't go
>> further because of other conflicts, and I'm ready to help to fix them.
>>
>> I just wanted to know if it is normal I didn't get any 'FAILED'
>> notifications like the ones Greg send [3]: I rely on them to know which
>> patches have been treated by the Stable team, but had conflicts. Will I
>> get these notifications later (no hurry), or should I not rely on them
>> to track fixes that could not be backported?
> 
> FAILED only happens for patches that explicitly have a "Cc: stable@" tag
> in a commit.  If you only have a "Fixes:" tag, that doesn't happen as we
> read that as "best effort if the stable team wants to add it".

That's clear and it makes sense. I will make sure not to miss the "Cc:
stable@" tag next time.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.