From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3004A143C7B; Thu, 13 Jun 2024 12:07:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280450; cv=none; b=lAGoN5TlGQcgBx4pqyBHpTx3W2UhdPEq1JKpJv01M7cpFAe61CJHL8WMwRtxFlypJNtIrNeTc/h+VUp0MvK+/jCdltaZ1y5/yWlWh6jni6sjycX09j+7xJ5VTMpAjCOQvrskny2M1zW9TvNLoVmA+jWtfkvcGaZ3o8CtxSgYIuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280450; c=relaxed/simple; bh=16RQvKe0T4Tn5NYOsEpKvxp3azjf6QQnhmjnnpDREME=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AiDGpMngTyqCiwmXP4AHLT4XGiPmaFLZ6S34iySgh7MsCmNk/1LqlRguKeQe2bd5Osv3LOhyNzhmq7+EKYruY+r1Au+3cOR7GZ8zhPaOyL6lfXBAYnP3PAmXJtfOjwuzgUU/bqMVLRzqen44ZOXlRpeePIF4ruNbD21Yn2EXI20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fnQI+rlh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fnQI+rlh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9BA4C2BBFC; Thu, 13 Jun 2024 12:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718280450; bh=16RQvKe0T4Tn5NYOsEpKvxp3azjf6QQnhmjnnpDREME=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fnQI+rlh1uTNV+JKdtYY3gJqwHgO3ULEOEL9ybPekazXsS+TSh6hf3qOzpNW3PskI shoJ9OHLI30XyrpFBAgda4KV9rtOoEjZB6A+Wq5E/mG+A9zZ2IOe47eX16G3qwMLZ+ PbwnTxDkufARyHVyTKYwhvN1CdQCzGc9MQ5OA/iA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tomi Valkeinen , Sakari Ailus , Hans Verkuil Subject: [PATCH 6.6 040/137] media: mc: Fix graph walk in media_pipeline_start Date: Thu, 13 Jun 2024 13:33:40 +0200 Message-ID: <20240613113224.845457245@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113223.281378087@linuxfoundation.org> References: <20240613113223.281378087@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tomi Valkeinen commit 8a9d420149c477e7c97fbd6453704e4612bdd3fa upstream. The graph walk tries to follow all links, even if they are not between pads. This causes a crash with, e.g. a MEDIA_LNK_FL_ANCILLARY_LINK link. Fix this by allowing the walk to proceed only for MEDIA_LNK_FL_DATA_LINK links. Signed-off-by: Tomi Valkeinen Cc: stable@vger.kernel.org # for 6.1 and later Fixes: ae219872834a ("media: mc: entity: Rewrite media_pipeline_start()") Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/mc/mc-entity.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/media/mc/mc-entity.c +++ b/drivers/media/mc/mc-entity.c @@ -606,6 +606,12 @@ static int media_pipeline_explore_next_l link = list_entry(entry->links, typeof(*link), list); last_link = media_pipeline_walk_pop(walk); + if ((link->flags & MEDIA_LNK_FL_LINK_TYPE) != MEDIA_LNK_FL_DATA_LINK) { + dev_dbg(walk->mdev->dev, + "media pipeline: skipping link (not data-link)\n"); + return 0; + } + dev_dbg(walk->mdev->dev, "media pipeline: exploring link '%s':%u -> '%s':%u\n", link->source->entity->name, link->source->index,