From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF9C3148302; Thu, 13 Jun 2024 11:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718279761; cv=none; b=bB7jeVlQ2ShFBf8X2qycsxwUnqJHlj9tZfCr7klkJWcsIq545c3ttSYyE3zY53QdvcicotMOrr4JqVe0p6EtuTX7WfHRQKkGHY8U8q117D+RsEcp+VxPKTlB2bB9gqadeFjjGQ+Ohvo4ztdrf9wIm8i7ZPJ0+SSWCrc+Yus5Ubo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718279761; c=relaxed/simple; bh=PhvCct5YWuJme/wH3W8JbJzTd+D4bnqkRZ+Dp5ht3ys=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N1kj5h1Q7CIdb03dK54d+llkLTccWRkprdYYxFwV6jVDFvix24/bVLvXRc8TlwkFtQq3uh+wUdiXFoeY5StruCAt+hDdOegcq72C7w7BS86puZoAnu/v8RfODtBntByHNWBNSdM9tPbURhuJLAPQxpIFKWrDE4n0UgrgWJ1yMeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rQsmkVnI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rQsmkVnI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C630C4AF1C; Thu, 13 Jun 2024 11:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718279761; bh=PhvCct5YWuJme/wH3W8JbJzTd+D4bnqkRZ+Dp5ht3ys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rQsmkVnIE3/0abXZdqH3Qxj9iimYn6CKMaG/VmAI9FWKaPvFnW5P6ub5qb6S01PWh w7hSwVpQ6AbZSOJCN4irXzY2mLgxNjTuDy2Kix8hhNWAbbdwE4PPRm6ItiDyQQoyQ2 hHimTbL1pEIcP2e9GofdQKkgA+Gyoyl6scntYpVY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guixiong Wei , Ingo Molnar , Kees Cook , Sasha Levin Subject: [PATCH 5.4 028/202] x86/boot: Ignore relocations in .notes sections in walk_relocs() too Date: Thu, 13 Jun 2024 13:32:06 +0200 Message-ID: <20240613113228.858768282@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113227.759341286@linuxfoundation.org> References: <20240613113227.759341286@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guixiong Wei [ Upstream commit 76e9762d66373354b45c33b60e9a53ef2a3c5ff2 ] Commit: aaa8736370db ("x86, relocs: Ignore relocations in .notes section") ... only started ignoring the .notes sections in print_absolute_relocs(), but the same logic should also by applied in walk_relocs() to avoid such relocations. [ mingo: Fixed various typos in the changelog, removed extra curly braces from the code. ] Fixes: aaa8736370db ("x86, relocs: Ignore relocations in .notes section") Fixes: 5ead97c84fa7 ("xen: Core Xen implementation") Fixes: da1a679cde9b ("Add /sys/kernel/notes") Signed-off-by: Guixiong Wei Signed-off-by: Ingo Molnar Reviewed-by: Kees Cook Link: https://lore.kernel.org/r/20240317150547.24910-1-weiguixiong@bytedance.com Signed-off-by: Sasha Levin --- arch/x86/tools/relocs.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c index 0043fd374a62f..f9ec998b7e946 100644 --- a/arch/x86/tools/relocs.c +++ b/arch/x86/tools/relocs.c @@ -689,6 +689,15 @@ static void walk_relocs(int (*process)(struct section *sec, Elf_Rel *rel, if (!(sec_applies->shdr.sh_flags & SHF_ALLOC)) { continue; } + + /* + * Do not perform relocations in .notes sections; any + * values there are meant for pre-boot consumption (e.g. + * startup_xen). + */ + if (sec_applies->shdr.sh_type == SHT_NOTE) + continue; + sh_symtab = sec_symtab->symtab; sym_strtab = sec_symtab->link->strtab; for (j = 0; j < sec->shdr.sh_size/sizeof(Elf_Rel); j++) { -- 2.43.0