From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E737146591; Thu, 13 Jun 2024 11:59:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718279941; cv=none; b=g2VYsunKLIhzIDL3bGlddbgxMkLji1QlJ4Y5MeZ6vpTiqY0f8nBGikca4ves6aztgpYroEgXXZhFMhCsZVUU3XMuemJ2FclHCC2k4WOxFUXXO51QFR45jtXXGfPpj/sGwZNQDm0jHyv5EbS4a53oIDQAXUNRL9pmQaY4JZOw8L0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718279941; c=relaxed/simple; bh=cge77/lmXEh1+1ZJKbAgnGQuAg48LxYnsMasvFlZ7vM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DxhfdbS2zFAGjY7uWAb9LllbBYZdyFny43RzQg/cu6SZnIqiTW6Lrp/2ywIecie5a0imfV8mKm6yLXDu+tHwWuPYuKwEHwtXyjlBelbKpC7ZIxTckHVJu/02G7gPFBsx+jM2glq+TSHoEsNd7duGQVRB+BFsZJAQbd+b3qzM1ms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=MDlRvfRw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="MDlRvfRw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15450C2BBFC; Thu, 13 Jun 2024 11:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718279941; bh=cge77/lmXEh1+1ZJKbAgnGQuAg48LxYnsMasvFlZ7vM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MDlRvfRwiZFJzeIE4+Iwo7Oq1gC4Q9PVk4enkLEUaQzML7nDUDYZHuOSqoXAFwZ7N i7KtsIMGvToWWzED2nyQIyBc5OXH+jushtnY89EhbSsHkOPwLqHGiMUgzdERFNdLkn 2bQet9wy2HDulnMqHV9cHCKBeY5KnuLMNFM/0o6o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Eric Dumazet , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 057/202] usb: aqc111: stop lying about skb->truesize Date: Thu, 13 Jun 2024 13:32:35 +0200 Message-ID: <20240613113229.978025763@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113227.759341286@linuxfoundation.org> References: <20240613113227.759341286@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit 9aad6e45c4e7d16b2bb7c3794154b828fb4384b4 ] Some usb drivers try to set small skb->truesize and break core networking stacks. I replace one skb_clone() by an allocation of a fresh and small skb, to get minimally sized skbs, like we did in commit 1e2c61172342 ("net: cdc_ncm: reduce skb truesize in rx path") and 4ce62d5b2f7a ("net: usb: ax88179_178a: stop lying about skb->truesize") Fixes: 361459cd9642 ("net: usb: aqc111: Implement RX data path") Signed-off-by: Eric Dumazet Link: https://lore.kernel.org/r/20240506135546.3641185-1-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/usb/aqc111.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index 892d58b38cf5b..b958e00058820 100644 --- a/drivers/net/usb/aqc111.c +++ b/drivers/net/usb/aqc111.c @@ -1141,17 +1141,15 @@ static int aqc111_rx_fixup(struct usbnet *dev, struct sk_buff *skb) continue; } - /* Clone SKB */ - new_skb = skb_clone(skb, GFP_ATOMIC); + new_skb = netdev_alloc_skb_ip_align(dev->net, pkt_len); if (!new_skb) goto err; - new_skb->len = pkt_len; + skb_put(new_skb, pkt_len); + memcpy(new_skb->data, skb->data, pkt_len); skb_pull(new_skb, AQ_RX_HW_PAD); - skb_set_tail_pointer(new_skb, new_skb->len); - new_skb->truesize = SKB_TRUESIZE(new_skb->len); if (aqc111_data->rx_checksum) aqc111_rx_checksum(new_skb, pkt_desc); -- 2.43.0