From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69094143899; Thu, 13 Jun 2024 11:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718279988; cv=none; b=A8cjYgv/FxBGDjhoWtImwvoEx1//GxI8FXeUf38TiGpJRLq4DGGPpKpzD/x2ZfE8RcfAChuGJTsZZMK7+o5PJZKjfZpD1xkr0xp6kmUKC1/PvElmxGs4X9DK9b62WsH6QV08LVNAKxVmnNwoulFw/zEIa6HLArdXR2CPleUxYoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718279988; c=relaxed/simple; bh=cAzDE7qyEok6twZT7drnt84XAQxLAIq4bgKwLzxRqBA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MPNx3UCx8DM8evNoGH7pIlCHQZqsViUxoYNjcXJAzAXg741i0LEWrbSfkzgfwELB2S/yg5LIs8PFJj1Qythob82WUwnonApQMPjw0kpE0esHDpyaVq9PgOx7wUQi1ZjBZePr7+FGXYCj2j2G7VgTqNqF8WRygRxbzT2679kbl/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hz9MDGWP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hz9MDGWP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7451C4AF50; Thu, 13 Jun 2024 11:59:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718279988; bh=cAzDE7qyEok6twZT7drnt84XAQxLAIq4bgKwLzxRqBA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hz9MDGWPgp2NGglMogZdNb/h1/fmd00bEs2S9UHFdh3iZR4T1H8nblaSwQ2nuwJcP 6VNkMlAB3y++w8E0yD2AmtrcVMukMslz0kvlAOxTA9sY+LZ22HZhQz9FgCqNr7klXx KMPOqD/sLyR81wJhI7n+Ktv/vOXTNUpuEsN/Zi+A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Edward Liaw , Cyrill Gorcunov , Eric Biederman , Shuah Khan , Andrew Morton , Sasha Levin Subject: [PATCH 5.4 087/202] selftests/kcmp: remove unused open mode Date: Thu, 13 Jun 2024 13:33:05 +0200 Message-ID: <20240613113231.128273853@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113227.759341286@linuxfoundation.org> References: <20240613113227.759341286@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Edward Liaw [ Upstream commit eb59a58113717df04b8a8229befd8ab1e5dbf86e ] Android bionic warns that open modes are ignored if O_CREAT or O_TMPFILE aren't specified. The permissions for the file are set above: fd1 = open(kpath, O_RDWR | O_CREAT | O_TRUNC, 0644); Link: https://lkml.kernel.org/r/20240429234610.191144-1-edliaw@google.com Fixes: d97b46a64674 ("syscalls, x86: add __NR_kcmp syscall") Signed-off-by: Edward Liaw Reviewed-by: Cyrill Gorcunov Cc: Eric Biederman Cc: Shuah Khan Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- tools/testing/selftests/kcmp/kcmp_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kcmp/kcmp_test.c b/tools/testing/selftests/kcmp/kcmp_test.c index 25110c7c0b3ed..d7a8e321bb16b 100644 --- a/tools/testing/selftests/kcmp/kcmp_test.c +++ b/tools/testing/selftests/kcmp/kcmp_test.c @@ -91,7 +91,7 @@ int main(int argc, char **argv) ksft_print_header(); ksft_set_plan(3); - fd2 = open(kpath, O_RDWR, 0644); + fd2 = open(kpath, O_RDWR); if (fd2 < 0) { perror("Can't open file"); ksft_exit_fail(); -- 2.43.0