From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47531146D48; Thu, 13 Jun 2024 12:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280045; cv=none; b=iFQjMLXpW+Ru07Mq+1pZKMoatHKFYiUkSE1itPOM5syO/xWBkpBdyq6MCu1sNhptuLoh2YkSBQXvIdGMcNvbBWPzQXYMDgdv3tVoES6kjLTF5hmXF4s7QUN02MR5uqthc2qLEyYwNyZhF1CbNW5nn1WUlEfBxOQ0EAiqXvtH5ds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280045; c=relaxed/simple; bh=jBGCFCE0zjvnIkognWBU1XI36NfKZCHN5/G+Dxv/ajs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bz7ig0sCiiRq497JWGCB9CSVmZwOnyxq23bHo0DxTcb0AgPJWA5u5MjJp8qRHpi/Pmz34j1KB+zUeolVLZHVQmQyiw6Nh4eQk6N0COoe66poBrxKnVIEIwdkHLsIMllnRgLLYpn2KOMy4meAuu5VKm/LimfliSVyRs0ObLiFqGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XpLgI1o/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XpLgI1o/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7319AC2BBFC; Thu, 13 Jun 2024 12:00:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718280044; bh=jBGCFCE0zjvnIkognWBU1XI36NfKZCHN5/G+Dxv/ajs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XpLgI1o/+cflzVX+IPekwaeCXIeChDVxYuWujZWBltyyA2xKnsrixOrtP/SrsQ9XD eIhAT5t+5yIoIgTA1Vh2RIobQ8/IuqOHwdLVxVc1ayvljqeaZv8ncd00wuSL6j9f0B omRpb5cfmllMuUd7NOTi2s5yVzJZLEo3Vw3fNfB4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Masami Hiramatsu , Adrian Hunter , Ian Rogers , Jiri Olsa , Namhyung Kim , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 5.4 093/202] perf probe: Add missing libgen.h header needed for using basename() Date: Thu, 13 Jun 2024 13:33:11 +0200 Message-ID: <20240613113231.358364548@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113227.759341286@linuxfoundation.org> References: <20240613113227.759341286@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnaldo Carvalho de Melo [ Upstream commit 581037151910126a7934e369e4b6ac70eda9a703 ] This prototype is obtained indirectly, by luck, from some other header in probe-event.c in most systems, but recently exploded on alpine:edge: 8 13.39 alpine:edge : FAIL gcc version 13.2.1 20240309 (Alpine 13.2.1_git20240309) util/probe-event.c: In function 'convert_exec_to_group': util/probe-event.c:225:16: error: implicit declaration of function 'basename' [-Werror=implicit-function-declaration] 225 | ptr1 = basename(exec_copy); | ^~~~~~~~ util/probe-event.c:225:14: error: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] 225 | ptr1 = basename(exec_copy); | ^ cc1: all warnings being treated as errors make[3]: *** [/git/perf-6.8.0/tools/build/Makefile.build:158: util] Error 2 Fix it by adding the libgen.h header where basename() is prototyped. Fixes: fb7345bbf7fad9bf ("perf probe: Support basic dwarf-based operations on uprobe events") Cc: Masami Hiramatsu Cc: Adrian Hunter Cc: Ian Rogers Cc: Jiri Olsa Cc: Namhyung Kim Link: https://lore.kernel.org/lkml/ Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/probe-event.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 67b7d2af1755d..1fe1c3ac2e4c9 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include -- 2.43.0