From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 136DD1474C5; Thu, 13 Jun 2024 12:00:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280054; cv=none; b=YUm4BfohqBR/KojeXku87bGybolow0JlmUT6UeKj48vgVEB1+vljI8adoSGVX0A5BnZvdxBlOni6L4IpPZhUlrIijWiIuka+XtmxrXkuKfP6GQjlXSBoAp4u6WI2HBnB8JCFl/7u2VT1rhcKzpifM1UqlPsaMuW+vU3l/+h6Hs8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280054; c=relaxed/simple; bh=4zAdV/GuLjMGw7QwUZkBc5SxBzNySq/0/5JtdGZgFk4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jnte8j+3AiRY+6HyliJGP8Sm82SmADVUpMLaEfWU1j/6ksXsBB7Sp7dk2TSKNCzfVxaG3RQXMmaKbhSAQEW696AtDBxQIz4Inl5niWAubql9yDUoOqOkq4OJVkhsfzBwW7msMOvmOHpQxnq9+eUL7xZOsr0jT5CCH+SzMK9jYuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Oz5toE5o; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Oz5toE5o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C92BC2BBFC; Thu, 13 Jun 2024 12:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718280053; bh=4zAdV/GuLjMGw7QwUZkBc5SxBzNySq/0/5JtdGZgFk4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Oz5toE5oICZDuEHeqsQATHPUPygb2ojQ73wNkP8pTukQt5JwwKkpTOhPDlEZKfiSk 9CwKOPMb0MKrOI52uldjvmIeiXYVwgVCyfXs6KaPQ6Jq0ilDYxmBF8XmLb+2IrBUeq Bg1llwo7Ls4YrmXOGgPD+Oq1IaPm91z1v+VhjUbc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ian Rogers , Adrian Hunter , Alexander Shishkin , Ingo Molnar , James Clark , Jiri Olsa , Kan Liang , Leo Yan , Mark Rutland , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 5.4 119/202] perf ui browser: Avoid SEGV on title Date: Thu, 13 Jun 2024 13:33:37 +0200 Message-ID: <20240613113232.355002433@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113227.759341286@linuxfoundation.org> References: <20240613113227.759341286@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ian Rogers [ Upstream commit 90f01afb0dfafbc9b094bb61e61a4ac297d9d0d2 ] If the title is NULL then it can lead to a SEGV. Fixes: 769e6a1e15bdbbaf ("perf ui browser: Don't save pointer to stack memory") Signed-off-by: Ian Rogers Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Ingo Molnar Cc: James Clark Cc: Jiri Olsa Cc: Kan Liang Cc: Leo Yan Cc: Mark Rutland Cc: Namhyung Kim Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20240508035301.1554434-2-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/ui/browser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c index 6fa4f123d5ff7..b84b87b939573 100644 --- a/tools/perf/ui/browser.c +++ b/tools/perf/ui/browser.c @@ -203,7 +203,7 @@ void ui_browser__refresh_dimensions(struct ui_browser *browser) void ui_browser__handle_resize(struct ui_browser *browser) { ui__refresh_dimensions(false); - ui_browser__show(browser, browser->title, ui_helpline__current); + ui_browser__show(browser, browser->title ?: "", ui_helpline__current); ui_browser__refresh(browser); } -- 2.43.0