From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 474B344C6F; Thu, 13 Jun 2024 12:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280130; cv=none; b=Rxg12v9lmbv4idAaflVe3kHSSxXdBxBhThxVKNrcRlD7KcrOQFYytcTJMhrfw0/Cakoq6Ms2uHNJyYWPmRKJHFx9SvjsryEkYLpGGYPkOfMlOrz+wBwjDO8MFpMk3dTAcIWyot6azYzf0uX8dXLboNcA6v8uX319775lI/ckcqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280130; c=relaxed/simple; bh=CLv8THNZZ6/nE0ibzqLJFtFMX0eLMROrIH4KY8fLIZ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LT8DE6Vhct6v1elDAmLhQKSe1kz2itGVA1fVau6JksTzUFb1rsaP++nJuHTOXNu9CEPrd4QBOwXnooMTk937H87pD9S7SySqQOVB58FF8bjZA8u+B70gztpZplchaoNCwRDpsmOdFYEV+d8puj/ETnnEq1EsVn8zDTIC3ckQpQ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=sIAwT4m0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="sIAwT4m0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F396C2BBFC; Thu, 13 Jun 2024 12:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718280130; bh=CLv8THNZZ6/nE0ibzqLJFtFMX0eLMROrIH4KY8fLIZ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sIAwT4m0AyTAaw5VAV95Mkl4CsdcSuK88ReG0RwI3gdbA9Z4wzh766nymD6FqKlK1 sSibPeFNQwLNzskL+0ZJ4mizvqqeyg6wmESFebqxNPOjZOnhmu1gs4LI5JX/5HWmhM d7FXye3DYn80FNy8GTQHTFgbkPfOLM5QjQzM0Fqs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ian Rogers , Adrian Hunter , Alexander Shishkin , Ingo Molnar , Jiri Olsa , Josh Poimboeuf , Kan Liang , Mark Rutland , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 5.4 122/202] libsubcmd: Fix parse-options memory leak Date: Thu, 13 Jun 2024 13:33:40 +0200 Message-ID: <20240613113232.470266460@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113227.759341286@linuxfoundation.org> References: <20240613113227.759341286@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ian Rogers [ Upstream commit 230a7a71f92212e723fa435d4ca5922de33ec88a ] If a usage string is built in parse_options_subcommand, also free it. Fixes: 901421a5bdf605d2 ("perf tools: Remove subcmd dependencies on strbuf") Signed-off-by: Ian Rogers Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Ingo Molnar Cc: Jiri Olsa Cc: Josh Poimboeuf Cc: Kan Liang Cc: Mark Rutland Cc: Namhyung Kim Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20240509052015.1914670-1-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/lib/subcmd/parse-options.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/lib/subcmd/parse-options.c b/tools/lib/subcmd/parse-options.c index dbb9efbf718a0..af440c1e80282 100644 --- a/tools/lib/subcmd/parse-options.c +++ b/tools/lib/subcmd/parse-options.c @@ -630,11 +630,10 @@ int parse_options_subcommand(int argc, const char **argv, const struct option *o const char *const subcommands[], const char *usagestr[], int flags) { struct parse_opt_ctx_t ctx; + char *buf = NULL; /* build usage string if it's not provided */ if (subcommands && !usagestr[0]) { - char *buf = NULL; - astrcatf(&buf, "%s %s [] {", subcmd_config.exec_name, argv[0]); for (int i = 0; subcommands[i]; i++) { @@ -676,7 +675,10 @@ int parse_options_subcommand(int argc, const char **argv, const struct option *o astrcatf(&error_buf, "unknown switch `%c'", *ctx.opt); usage_with_options(usagestr, options); } - + if (buf) { + usagestr[0] = NULL; + free(buf); + } return parse_options_end(&ctx); } -- 2.43.0