From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49EF2144303; Thu, 13 Jun 2024 12:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280276; cv=none; b=umNzkEau4l7WBPlQXaLd57CACmoRqYX7ontqDroGoOhMjVioL5VBugp6u1SM+bKxihUWbJKwNB3uyRaQSq5gXVZiYdVpw7BwJLBDPRBXFCCWPzN0VVrwx6h+sEitAfZ+8I7IRQHbpnC0idiwM4Q+7xvYbSbfpR4reFMgmEgDALs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280276; c=relaxed/simple; bh=Hm+DjUXPmuyGSmxbdydQqvAsLJoQ1clnDTa7VhjTw8o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mgxTKBVA+IodrSxWVICDsamYrNXjBn0CkcpVJaMRsQ8xu4mMjiUjZM7lFQLu+n82uR8V3LPtKs1058cJUCWprC7SeEboYKlthybhoIoenX6eEFzBEjfJvPAYFabqIPCy3Kirj64e2Y5eFJwhKR5lvRRylNK8leSW2RCo1UsVX1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XLQrAvDe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XLQrAvDe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1B59C2BBFC; Thu, 13 Jun 2024 12:04:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718280276; bh=Hm+DjUXPmuyGSmxbdydQqvAsLJoQ1clnDTa7VhjTw8o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XLQrAvDeN2N83CoHspw8RYYNS4MkJBGz5y0iTxdW24gHLq+8kl5Gn6loJ+V8e9ZXl IReMU+Rrta6F2Snb/htMWajdTGCZldSdfyvyupLrz81oKsSpcMgEujty6xp0sNAEdY bm9KlE/6ul+0U15aBe+MnpiljAOL+6cGFmzMGpF4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sergey Shtylyov , Benjamin Coddington , Trond Myklebust Subject: [PATCH 5.4 202/202] nfs: fix undefined behavior in nfs_block_bits() Date: Thu, 13 Jun 2024 13:35:00 +0200 Message-ID: <20240613113235.534548096@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113227.759341286@linuxfoundation.org> References: <20240613113227.759341286@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sergey Shtylyov commit 3c0a2e0b0ae661457c8505fecc7be5501aa7a715 upstream. Shifting *signed int* typed constant 1 left by 31 bits causes undefined behavior. Specify the correct *unsigned long* type by using 1UL instead. Found by Linux Verification Center (linuxtesting.org) with the Svace static analysis tool. Cc: stable@vger.kernel.org Signed-off-by: Sergey Shtylyov Reviewed-by: Benjamin Coddington Signed-off-by: Trond Myklebust Signed-off-by: Greg Kroah-Hartman --- fs/nfs/internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/nfs/internal.h +++ b/fs/nfs/internal.h @@ -609,9 +609,9 @@ unsigned long nfs_block_bits(unsigned lo if ((bsize & (bsize - 1)) || nrbitsp) { unsigned char nrbits; - for (nrbits = 31; nrbits && !(bsize & (1 << nrbits)); nrbits--) + for (nrbits = 31; nrbits && !(bsize & (1UL << nrbits)); nrbits--) ; - bsize = 1 << nrbits; + bsize = 1UL << nrbits; if (nrbitsp) *nrbitsp = nrbits; }