From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8002E1422DD; Thu, 13 Jun 2024 12:12:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280741; cv=none; b=lBnc30T8CXNv5iJ6VvpkdGNCM1pjT1CUfS6OT7zE4Vyt2/5RLAFBkpSrvRBProf7sXAjsltiIp/6JfGsRACXX4XN60/bSOiN6QHVSKQMKAeOXfU1xRNrjwmjBwQc2pcaKLbdcG5SphpU5POu37vCMpCmyVgbhCSvwWwmYLmTyxs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280741; c=relaxed/simple; bh=Z2uh7O2Y9lm9Qc3ulRDNPYVlVtLGiZ+eho7cJBAwqx8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mErq14h2KBcsZF1n3ejh3eW7UQa7/la2knbUD31Ud0ZWVw+6pC8cXzIDYS0vvtLwsSxNpAPq8Xq7oSRpeJ2MDoxWkvLyLIHwEe91Op9T+2gC0QhtWbghguYzJb3k4mCFhyTffGQDVo6Qu+7SLPBNwfPgkvgjOp+IEXGxZAihL/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=y/YeFz1F; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="y/YeFz1F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 053BDC2BBFC; Thu, 13 Jun 2024 12:12:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718280741; bh=Z2uh7O2Y9lm9Qc3ulRDNPYVlVtLGiZ+eho7cJBAwqx8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y/YeFz1FBcGBqRXidiRMdAiNsACizK4dKdoOBeEWtZ5fsgaYB4yoFtBmLHVhLGELO 8QIJ/li3B9kYN3f3u8OMMb9XtOkk1zDAd/lvCFp/ud98RotN4hMtIjgA2rNzGbzbSV pu0c95jpEHs4Bzq418OUNaB2Rr0ZiekBbt8J8Yzo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nilay Shroff , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Keith Busch , Sasha Levin Subject: [PATCH 5.10 019/317] nvme: find numa distance only if controller has valid numa id Date: Thu, 13 Jun 2024 13:30:37 +0200 Message-ID: <20240613113248.285099106@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113247.525431100@linuxfoundation.org> References: <20240613113247.525431100@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nilay Shroff [ Upstream commit 863fe60ed27f2c85172654a63c5b827e72c8b2e6 ] On system where native nvme multipath is configured and iopolicy is set to numa but the nvme controller numa node id is undefined or -1 (NUMA_NO_NODE) then avoid calculating node distance for finding optimal io path. In such case we may access numa distance table with invalid index and that may potentially refer to incorrect memory. So this patch ensures that if the nvme controller numa node id is -1 then instead of calculating node distance for finding optimal io path, we set the numa node distance of such controller to default 10 (LOCAL_DISTANCE). Link: https://lore.kernel.org/all/20240413090614.678353-1-nilay@linux.ibm.com/ Signed-off-by: Nilay Shroff Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Reviewed-by: Chaitanya Kulkarni Signed-off-by: Keith Busch Signed-off-by: Sasha Levin --- drivers/nvme/host/multipath.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c index 379d6818a0635..9f59f93b70e26 100644 --- a/drivers/nvme/host/multipath.c +++ b/drivers/nvme/host/multipath.c @@ -168,7 +168,8 @@ static struct nvme_ns *__nvme_find_path(struct nvme_ns_head *head, int node) if (nvme_path_is_disabled(ns)) continue; - if (READ_ONCE(head->subsys->iopolicy) == NVME_IOPOLICY_NUMA) + if (ns->ctrl->numa_node != NUMA_NO_NODE && + READ_ONCE(head->subsys->iopolicy) == NVME_IOPOLICY_NUMA) distance = node_distance(node, ns->ctrl->numa_node); else distance = LOCAL_DISTANCE; -- 2.43.0