From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3327145FEE; Thu, 13 Jun 2024 12:21:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718281281; cv=none; b=ZyWj6RiPbatCvWllRFp3w7b0K+UM51jCjMQ6kGiQusIKXa/NuxdMr7QCN74qdSMTLca+ah+7oEJrUcTtp1TTreY9Vk6RiE5yaYRC7KTNjJfeIIENicQft+EeJVBIRoYAsPfO5tWdRj0g+R3eVhLMKMLSnwMwydwfDKT07+erstE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718281281; c=relaxed/simple; bh=y4FG00olSTX5HsD6vKQDkdie5ig3MVgM1Y8xLTQ2uTk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mls30yik7Ty3jTyGjMReMLmGK2Wbk4wjV3S5JKjqbl0p5JAEqwLoIDILAinZZIaX9SrygNn0Ayu9DuV8xCvK+KM9xn217rB5cADyRywKqoVRUsMSpGKxOs/s2AVwzXN7mt8vWFiEZXRsMIBqCGVo8hAaiRHJTRLcfwdClc3DTh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=o6G5scDA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="o6G5scDA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A72FC2BBFC; Thu, 13 Jun 2024 12:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718281280; bh=y4FG00olSTX5HsD6vKQDkdie5ig3MVgM1Y8xLTQ2uTk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o6G5scDA9hO5sNrGMF21lSa8JNSF2VW4hlKPqPatXwMz425Le36zPK+PQwogjt50+ LoZQv54wwQwffcg8YP389vGXJtDDnTWnFiH2C7b/bUzSXw2VdkrsoxtdrFREJqSOwO B7b6+spd51I6/xnVbMMrIAJtyud06PVSmIq+9n2k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Haemmerle , Jonathan Cameron , Sasha Levin Subject: [PATCH 5.10 162/317] iio: pressure: dps310: support negative temperature values Date: Thu, 13 Jun 2024 13:33:00 +0200 Message-ID: <20240613113253.832341347@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113247.525431100@linuxfoundation.org> References: <20240613113247.525431100@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Haemmerle [ Upstream commit 9dd6b32e76ff714308964cd9ec91466a343dcb8b ] The current implementation interprets negative values returned from `dps310_calculate_temp` as error codes. This has a side effect that when negative temperature values are calculated, they are interpreted as error. Fix this by using the return value only for error handling and passing a pointer for the value. Fixes: ba6ec48e76bc ("iio: Add driver for Infineon DPS310") Signed-off-by: Thomas Haemmerle Link: https://lore.kernel.org/r/20240415105030.1161770-2-thomas.haemmerle@leica-geosystems.com Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/pressure/dps310.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/iio/pressure/dps310.c b/drivers/iio/pressure/dps310.c index 1b6b9530f1662..7fdc7a0147f0e 100644 --- a/drivers/iio/pressure/dps310.c +++ b/drivers/iio/pressure/dps310.c @@ -730,7 +730,7 @@ static int dps310_read_pressure(struct dps310_data *data, int *val, int *val2, } } -static int dps310_calculate_temp(struct dps310_data *data) +static int dps310_calculate_temp(struct dps310_data *data, int *val) { s64 c0; s64 t; @@ -746,7 +746,9 @@ static int dps310_calculate_temp(struct dps310_data *data) t = c0 + ((s64)data->temp_raw * (s64)data->c1); /* Convert to milliCelsius and scale the temperature */ - return (int)div_s64(t * 1000LL, kt); + *val = (int)div_s64(t * 1000LL, kt); + + return 0; } static int dps310_read_temp(struct dps310_data *data, int *val, int *val2, @@ -768,11 +770,10 @@ static int dps310_read_temp(struct dps310_data *data, int *val, int *val2, if (rc) return rc; - rc = dps310_calculate_temp(data); - if (rc < 0) + rc = dps310_calculate_temp(data, val); + if (rc) return rc; - *val = rc; return IIO_VAL_INT; case IIO_CHAN_INFO_OVERSAMPLING_RATIO: -- 2.43.0