From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79ADD145A03; Thu, 13 Jun 2024 12:19:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718281195; cv=none; b=DF4zJfH+bcYnQns9JvhP1djMwLuNe6/sJ9fMxfKTD+UxiMm19mNjVNXyAe/4JnoTA14Eqq35M0z7fWiiDG8E/eT9R+cYl5SRpGDiFYQitfklyuFzvwka6DNmkJVJoORsnBl/u508DAJEv/142PxtbA9AL4KqngYz5eZ1WSzYXeI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718281195; c=relaxed/simple; bh=xaCef+gpcHO1vjKUA9/sYlksDUNnPaiADf6F+lLn324=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EpfBC6cSiv87eC1j9sxgz42Ri9sOau7c943P35mrShUQUJS39sf64RNdo/L4gJSblQKeqyZWXCGOsSpST287HmtNgN9gwn5LtdRcC33PG5dUah+/gnUhuJGDzZk8/dxTzG0ZeexPVXuB1/Xb97jAzJ5iPWd7hevmTL07DGbczG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=a4yc2fwg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="a4yc2fwg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F33A3C32786; Thu, 13 Jun 2024 12:19:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718281195; bh=xaCef+gpcHO1vjKUA9/sYlksDUNnPaiADf6F+lLn324=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a4yc2fwg0lcoB+YbwtId/cvk+1B4rJsJ4OsxSs9cx5BrqyKKIj1/Ck2lnNJkvbyCK TA31ws9swIDs6+HH4+4ksyRCTZ0bBsnHNaMeMyxC1ZlP6XxsVJEpzhEVmDh410iK5y F0+E4Vm2yQv5RTjUVx8jEF0CVCrn9UDeHIHjJMQw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Amelie Delaunay , Andy Shevchenko , Alexander Shishkin , Sasha Levin Subject: [PATCH 5.10 173/317] stm class: Fix a double free in stm_register_device() Date: Thu, 13 Jun 2024 13:33:11 +0200 Message-ID: <20240613113254.252151453@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113247.525431100@linuxfoundation.org> References: <20240613113247.525431100@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit 3df463865ba42b8f88a590326f4c9ea17a1ce459 ] The put_device(&stm->dev) call will trigger stm_device_release() which frees "stm" so the vfree(stm) on the next line is a double free. Fixes: 389b6699a2aa ("stm class: Fix stm device initialization order") Signed-off-by: Dan Carpenter Reviewed-by: Amelie Delaunay Reviewed-by: Andy Shevchenko Signed-off-by: Alexander Shishkin Link: https://lore.kernel.org/r/20240429130119.1518073-2-alexander.shishkin@linux.intel.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/hwtracing/stm/core.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c index 2712e699ba08c..ae9ea3a1fa2aa 100644 --- a/drivers/hwtracing/stm/core.c +++ b/drivers/hwtracing/stm/core.c @@ -868,8 +868,11 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data, return -ENOMEM; stm->major = register_chrdev(0, stm_data->name, &stm_fops); - if (stm->major < 0) - goto err_free; + if (stm->major < 0) { + err = stm->major; + vfree(stm); + return err; + } device_initialize(&stm->dev); stm->dev.devt = MKDEV(stm->major, 0); @@ -913,10 +916,8 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data, err_device: unregister_chrdev(stm->major, stm_data->name); - /* matches device_initialize() above */ + /* calls stm_device_release() */ put_device(&stm->dev); -err_free: - vfree(stm); return err; } -- 2.43.0