From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B45BC56458; Thu, 13 Jun 2024 12:24:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718281477; cv=none; b=GcTE1dCxbCfs36aFINBYnQSpMFu8jzh1qy9hEnxvcXgzKsuBrdBTWZrUFzSx7fW6PbLEkequBVV3VWd+/8ZnviMDV+URO/f4Mm33H07LcsmTiAQQYw9hYfMoJYoBvJgrZCXhbjsFyrtjXFaSwF6VZwnn0xZNPzMp8/U+Dnnf0ew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718281477; c=relaxed/simple; bh=UxekyblV+rITJuc/EivK4/HjeU+PV8Zs7OHMQuVfvws=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ncfeAIkpKlYNgMv1xKxWVWHrxhyi8SwCWKTxqHaHtDBvrnyhmVI/t3SjjvLATCHpJFzD77s+XR4p3qzrvxtxVmfiNiaFefW8Hlo8RLQvjTAgMbnx3/3KBaVnl/EjY5ORLv3V+uwfujM2ifezplRfLorax/PrELKoyUH6JG+QamA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=m75wbf4Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="m75wbf4Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39C0EC2BBFC; Thu, 13 Jun 2024 12:24:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718281477; bh=UxekyblV+rITJuc/EivK4/HjeU+PV8Zs7OHMQuVfvws=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m75wbf4ZF26vWpISk3LfgnHK5IEJgu/MsuIXxIz7Ly1ZFzhvvqm0sr59CTNA7DgPH FKMI0nacVA9yz02J2e134SQTuUCM5KptYlN+WSDUjopXDKUkSwtdSLpyFMPC1sg0gX UNyR/msr0Vkbsg24RGid4Y4sGnkcf7n17EcTLVHQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Masahiro Yamada , "Borislav Petkov (AMD)" , Josh Poimboeuf , Sasha Levin Subject: [PATCH 5.10 227/317] x86/kconfig: Select ARCH_WANT_FRAME_POINTERS again when UNWINDER_FRAME_POINTER=y Date: Thu, 13 Jun 2024 13:34:05 +0200 Message-ID: <20240613113256.333336031@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113247.525431100@linuxfoundation.org> References: <20240613113247.525431100@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Masahiro Yamada [ Upstream commit 66ee3636eddcc82ab82b539d08b85fb5ac1dff9b ] It took me some time to understand the purpose of the tricky code at the end of arch/x86/Kconfig.debug. Without it, the following would be shown: WARNING: unmet direct dependencies detected for FRAME_POINTER because 81d387190039 ("x86/kconfig: Consolidate unwinders into multiple choice selection") removed 'select ARCH_WANT_FRAME_POINTERS'. The correct and more straightforward approach should have been to move it where 'select FRAME_POINTER' is located. Several architectures properly handle the conditional selection of ARCH_WANT_FRAME_POINTERS. For example, 'config UNWINDER_FRAME_POINTER' in arch/arm/Kconfig.debug. Fixes: 81d387190039 ("x86/kconfig: Consolidate unwinders into multiple choice selection") Signed-off-by: Masahiro Yamada Signed-off-by: Borislav Petkov (AMD) Acked-by: Josh Poimboeuf Link: https://lore.kernel.org/r/20240204122003.53795-1-masahiroy@kernel.org Signed-off-by: Sasha Levin --- arch/x86/Kconfig.debug | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug index 27b5e2bc6a016..e6546aa448de1 100644 --- a/arch/x86/Kconfig.debug +++ b/arch/x86/Kconfig.debug @@ -258,6 +258,7 @@ config UNWINDER_ORC config UNWINDER_FRAME_POINTER bool "Frame pointer unwinder" + select ARCH_WANT_FRAME_POINTERS select FRAME_POINTER help This option enables the frame pointer unwinder for unwinding kernel @@ -281,7 +282,3 @@ config UNWINDER_GUESS overhead. endchoice - -config FRAME_POINTER - depends on !UNWINDER_ORC && !UNWINDER_GUESS - bool -- 2.43.0