From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5BC2140391; Thu, 13 Jun 2024 12:23:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718281439; cv=none; b=m0QvcX2tzevVR14Q36nHrKcQ10HELuasGucSgTSzjladvQzz8c2g5uT5Rff7J1U21OQtrLrMM/9eOeVlSzLzaf3QP3y5yS96GVu3tbWfbUZRwiVzDB4XywUQWWtLDZCVMiHi1HgGTGpcZwo5fc5ObXrmhm7uzliAGJuMlsBocZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718281439; c=relaxed/simple; bh=HoTuVgK3RwPH/AiDsChYmjRQLEy6V9zhp9GsiOSE43Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kz45oumgEr5o+yBXMnFfxpWuEydxLNSECo5t7l5jjI7ahQUplTc/mxGun7nRkEF0IOWrCrhlj7r3PkuP3ZWEn6doA4hHAxtEjGzW0DNB6cq3N8Uw2YzFiHhweW595pajCCuynsGBYE3TCzuYJ3O1HRCpnPxsXIyW9mSSLn8tDh0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FpBm5RfF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FpBm5RfF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 325A5C2BBFC; Thu, 13 Jun 2024 12:23:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718281439; bh=HoTuVgK3RwPH/AiDsChYmjRQLEy6V9zhp9GsiOSE43Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FpBm5RfFcOagpFW1+UGrUzYGN9+47lSZsLEAcwDZUuUL/BmqgJsNc0ZGaDclbm+8Y xm7chIb96qpsLABEKBEj2og7mSFjeJzGl0dOhVq1Y7UYWNQGuSTL1nQV1MBh0GsS9n ltoqqr3xmfpOQ8vXkZFzxXfW/1VNRMWS0BXqXhwo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiaolei Wang , Wei Fang , Andrew Lunn , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 255/317] net:fec: Add fec_enet_deinit() Date: Thu, 13 Jun 2024 13:34:33 +0200 Message-ID: <20240613113257.413749274@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113247.525431100@linuxfoundation.org> References: <20240613113247.525431100@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xiaolei Wang [ Upstream commit bf0497f53c8535f99b72041529d3f7708a6e2c0d ] When fec_probe() fails or fec_drv_remove() needs to release the fec queue and remove a NAPI context, therefore add a function corresponding to fec_enet_init() and call fec_enet_deinit() which does the opposite to release memory and remove a NAPI context. Fixes: 59d0f7465644 ("net: fec: init multi queue date structure") Signed-off-by: Xiaolei Wang Reviewed-by: Wei Fang Reviewed-by: Andrew Lunn Link: https://lore.kernel.org/r/20240524050528.4115581-1-xiaolei.wang@windriver.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/fec_main.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index fe29769cb1589..adb76db66031f 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3443,6 +3443,14 @@ static int fec_enet_init(struct net_device *ndev) return ret; } +static void fec_enet_deinit(struct net_device *ndev) +{ + struct fec_enet_private *fep = netdev_priv(ndev); + + netif_napi_del(&fep->napi); + fec_enet_free_queue(ndev); +} + #ifdef CONFIG_OF static int fec_reset_phy(struct platform_device *pdev) { @@ -3813,6 +3821,7 @@ fec_probe(struct platform_device *pdev) fec_enet_mii_remove(fep); failed_mii_init: failed_irq: + fec_enet_deinit(ndev); failed_init: fec_ptp_stop(pdev); failed_reset: @@ -3874,6 +3883,7 @@ fec_drv_remove(struct platform_device *pdev) pm_runtime_put_noidle(&pdev->dev); pm_runtime_disable(&pdev->dev); + fec_enet_deinit(ndev); free_netdev(ndev); return 0; } -- 2.43.0