From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3C191422AB; Thu, 13 Jun 2024 12:24:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718281480; cv=none; b=cPDy0oXUKX27nrFO0LwW0mdveE4HRu9YL7T5s4XAsgwEfdUBQluQKCoAtLZVVui6/rztoRFT5B3r9d5mO11vWYSB4Al27+RXJhJ+J4jqP5k7aur6WrHl3cgkBDSzEKXcFPVuT9RSklvLcHXHzEBnIDUgm+b/Y6L4AA5QThnMDGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718281480; c=relaxed/simple; bh=gl7KiVdXz9ZtFIHpHJvOZhp3P42RALb7+5t/hUK2/04=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pDkh+KWL+y7XWsi8mzN2Xc+sOlP01oLQIUccSB/Bm3zaKSAhsHpHHUh0ckkrYGs8CaKYUbwe0evVCiomFvp6s0C+7DlGc6oppROUDDFOOI9xUEN2MoRQzWEXbnfX4/uPiZf9ml5sZsJ8RDbuov71kf88ys4YqTB2XLO8QinHQuE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nP0uX805; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nP0uX805" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28041C4AF1A; Thu, 13 Jun 2024 12:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718281480; bh=gl7KiVdXz9ZtFIHpHJvOZhp3P42RALb7+5t/hUK2/04=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nP0uX805cY+JbPk0xBpOqYO47euaEU70iQfRx1aprzBeKdiP0Qk71X6tsYWOzvPfT thPjFuBLPEmVEYzUVYuI9X3D6vy2euxW5oR0T/tcY6OrGRxebVjo0Y+7M6LUkPvGUT 1NLmzLHE/QMAa4StnigzQeNBJZJ3ej+54xv+IXJw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+43120c2af6ca2938cc38@syzkaller.appspotmail.com, Takashi Iwai Subject: [PATCH 5.10 262/317] ALSA: timer: Set lower bound of start tick time Date: Thu, 13 Jun 2024 13:34:40 +0200 Message-ID: <20240613113257.682209419@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113247.525431100@linuxfoundation.org> References: <20240613113247.525431100@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takashi Iwai commit 4a63bd179fa8d3fcc44a0d9d71d941ddd62f0c4e upstream. Currently ALSA timer doesn't have the lower limit of the start tick time, and it allows a very small size, e.g. 1 tick with 1ns resolution for hrtimer. Such a situation may lead to an unexpected RCU stall, where the callback repeatedly queuing the expire update, as reported by fuzzer. This patch introduces a sanity check of the timer start tick time, so that the system returns an error when a too small start size is set. As of this patch, the lower limit is hard-coded to 100us, which is small enough but can still work somehow. Reported-by: syzbot+43120c2af6ca2938cc38@syzkaller.appspotmail.com Closes: https://lore.kernel.org/r/000000000000fa00a1061740ab6d@google.com Cc: Link: https://lore.kernel.org/r/20240514182745.4015-1-tiwai@suse.de Signed-off-by: Takashi Iwai [ backport note: the error handling is changed, as the original commit is based on the recent cleanup with guard() in commit beb45974dd49 -- tiwai ] Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/core/timer.c | 10 ++++++++++ 1 file changed, 10 insertions(+) --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -553,6 +553,16 @@ static int snd_timer_start1(struct snd_t goto unlock; } + /* check the actual time for the start tick; + * bail out as error if it's way too low (< 100us) + */ + if (start) { + if ((u64)snd_timer_hw_resolution(timer) * ticks < 100000) { + result = -EINVAL; + goto unlock; + } + } + if (start) timeri->ticks = timeri->cticks = ticks; else if (!timeri->cticks)