From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3198614431F; Thu, 13 Jun 2024 12:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718281504; cv=none; b=sCeMoBycdBWrQRJfdwpXiUu2vHnAO5ztXGQ9Ogt4t0mMls362BVNcUUG8+FIyvsZHtnyC1FRFzSnpYMURWIX68dnBXyI4WEOmTYTdbsHqJUdOflxtBvJYR7hY+OYY8kNCaLu2Xj0LFUoh0qqz9bDP8CkiYgcYHp7FyXPrYDECsM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718281504; c=relaxed/simple; bh=UY5C6jRjJ0ZhmPcM+4WyDnrsc4eOqBu7eu4LPd18jdQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FhSh941K28N/L7D1ThDn+Jb6jbbvkw3xXJaQwAl3dsCVGF5P8x6P5Pyyx/SN6Q4YghpCFr2kiNIrb7ckgJoC+rWkuQTfhvlerD4j2PHZmHP4UTd0Mfy/qyw4rOHvYXWbbmxQzoaozJBeQnqWnkdDCrt+77hKurxK/OC5Eergiak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dj4cKnp7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dj4cKnp7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B15DAC2BBFC; Thu, 13 Jun 2024 12:25:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718281504; bh=UY5C6jRjJ0ZhmPcM+4WyDnrsc4eOqBu7eu4LPd18jdQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dj4cKnp78ALm3rKystUhiRnrtzA1BBLkIN0AxbZ8MIEB6MpjmmQY+x1ORGycGgu5T TpOFbTeBHVlMCzJYdT69vY5JlxhtFIgXIN0cmsMsxWTR32pssxGBQvRHZfuhAYP8y3 F6a2s3gLom1v48huXwAsZ5V1IThKcN+qNpz3xE6E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sergey Shtylyov , Niklas Cassel , Damien Le Moal Subject: [PATCH 5.10 278/317] ata: pata_legacy: make legacy_exit() work again Date: Thu, 13 Jun 2024 13:34:56 +0200 Message-ID: <20240613113258.305387232@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113247.525431100@linuxfoundation.org> References: <20240613113247.525431100@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sergey Shtylyov commit d4a89339f17c87c4990070e9116462d16e75894f upstream. Commit defc9cd826e4 ("pata_legacy: resychronize with upstream changes and resubmit") missed to update legacy_exit(), so that it now fails to do any cleanup -- the loop body there can never be entered. Fix that and finally remove now useless nr_legacy_host variable... Found by Linux Verification Center (linuxtesting.org) with the Svace static analysis tool. Fixes: defc9cd826e4 ("pata_legacy: resychronize with upstream changes and resubmit") Cc: stable@vger.kernel.org Signed-off-by: Sergey Shtylyov Reviewed-by: Niklas Cassel Signed-off-by: Damien Le Moal Signed-off-by: Greg Kroah-Hartman --- drivers/ata/pata_legacy.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/ata/pata_legacy.c +++ b/drivers/ata/pata_legacy.c @@ -114,8 +114,6 @@ static int legacy_port[NR_HOST] = { 0x1f static struct legacy_probe probe_list[NR_HOST]; static struct legacy_data legacy_data[NR_HOST]; static struct ata_host *legacy_host[NR_HOST]; -static int nr_legacy_host; - static int probe_all; /* Set to check all ISA port ranges */ static int ht6560a; /* HT 6560A on primary 1, second 2, both 3 */ @@ -1239,9 +1237,11 @@ static __exit void legacy_exit(void) { int i; - for (i = 0; i < nr_legacy_host; i++) { + for (i = 0; i < NR_HOST; i++) { struct legacy_data *ld = &legacy_data[i]; - ata_host_detach(legacy_host[i]); + + if (legacy_host[i]) + ata_host_detach(legacy_host[i]); platform_device_unregister(ld->platform_dev); } }