From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C329144313; Thu, 13 Jun 2024 12:38:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718282298; cv=none; b=gRepDT67nrKMznKqx5nSdxu9mkyxPvp3nrmVfaTfJJN2VkuucUqoEN3EROP/fSI4EK6f+J90rl1gJJvS3Zt+MMjjOcZxxpmXstu8WhQ3IiyodsTgGOzi3u3u7See+599fDAUTJArXdKKWMDNAO7sV9vWj50LsYmVWICBhCzyE/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718282298; c=relaxed/simple; bh=6nZ2p4sNZT/s0w+jy7lGeEAxZRrmPMxb2d6L/48Hkf4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hPNcT4CmgkGpCrvunUTACMbaJZrNf/bgjwFl4WNq2qClo+nUqdFqYdpWfdjqOgB88ZoSxiH1v89wOwmHwOf4oFiNRIO+/mH+r209Ail2+1Wk8swoOwAqZHlwepTfsI1aBWG6DJ9x69pkFzAmxEDrlUdXkOIdEl5I9MsxuDq+qfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wKVZANzv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wKVZANzv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBEA4C4AF4D; Thu, 13 Jun 2024 12:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718282298; bh=6nZ2p4sNZT/s0w+jy7lGeEAxZRrmPMxb2d6L/48Hkf4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wKVZANzvnFtfBKA1T5Mp4HfHOp2A7wev5bh4UT59/8nsbTX0Z8eQ9yGcDqkhqY6VO 3ZZECTaEpkCwNuS3b54jrGs/VH5l+01V3egArc0SkTkiEYpR8cJX+YmN2xnFkqNJn0 S0B+NeVBI/4q0ywzbkM1Bp3sTDQp4LzTVN2PB7X0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ian Rogers , Adrian Hunter , Alexander Shishkin , Ingo Molnar , James Clark , Jiri Olsa , Kan Liang , Leo Yan , Mark Rutland , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 5.15 230/402] perf ui browser: Avoid SEGV on title Date: Thu, 13 Jun 2024 13:33:07 +0200 Message-ID: <20240613113311.117324009@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113302.116811394@linuxfoundation.org> References: <20240613113302.116811394@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ian Rogers [ Upstream commit 90f01afb0dfafbc9b094bb61e61a4ac297d9d0d2 ] If the title is NULL then it can lead to a SEGV. Fixes: 769e6a1e15bdbbaf ("perf ui browser: Don't save pointer to stack memory") Signed-off-by: Ian Rogers Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Ingo Molnar Cc: James Clark Cc: Jiri Olsa Cc: Kan Liang Cc: Leo Yan Cc: Mark Rutland Cc: Namhyung Kim Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20240508035301.1554434-2-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/ui/browser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c index d09b4cbec6e06..5d6f4f25c33d0 100644 --- a/tools/perf/ui/browser.c +++ b/tools/perf/ui/browser.c @@ -203,7 +203,7 @@ void ui_browser__refresh_dimensions(struct ui_browser *browser) void ui_browser__handle_resize(struct ui_browser *browser) { ui__refresh_dimensions(false); - ui_browser__show(browser, browser->title, ui_helpline__current); + ui_browser__show(browser, browser->title ?: "", ui_helpline__current); ui_browser__refresh(browser); } -- 2.43.0