From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 769C914198E; Thu, 13 Jun 2024 12:38:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718282311; cv=none; b=BFO26sh2kh4LhRgT+Nmt0u0up+2qbNl+XkliIic1IcWQi1QikQQpZ9Uykz9HciY9TVH8A89S+035D2x0f5a3/vEQJCi/S5HF3LkfSA+45nDlrK+tS6myEJ+MeAB4yre8w/8//g8URXWAOJOvIFwDpq6N2ewv1mO1JRcD0piGgF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718282311; c=relaxed/simple; bh=pIY1Qo317bxf4jAy5Y0W/bcWml82og9i0/jZa5OCaU4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XormJQ1QaZvLCpNbN1yBRxL+kEebb22nBYgVYT7taW7uuMi+QaGICLYzyOYLmuMN05BtSG0eOw83yEM9A6SLyJWXiGKbQHPNfTyQGckSlJPK++fNSVa7i59lqre1NLedEDMGeYKjuPJxCk718BT5vc5r2X2T6TOyzUsXh/Jv/FU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cGODDEi2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cGODDEi2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD235C4AF1A; Thu, 13 Jun 2024 12:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718282310; bh=pIY1Qo317bxf4jAy5Y0W/bcWml82og9i0/jZa5OCaU4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cGODDEi2721Ftsu+bgSoULJPOHfxB41DGh8HRhhFLusjlOcFRdMmqU5EMxQ0yIHbE N0s6quhkLsY0pGWrUlzchVS2EyJePC3C07NKokmALyfLa1WUYaVxHCNb2CAvRMB28A kpRPa6mg2opc96eY7tTnrSMU9wlOHkbTR661UoKw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chao Yu , Jaegeuk Kim , Sasha Levin Subject: [PATCH 5.15 234/402] f2fs: compress: dont allow unaligned truncation on released compress inode Date: Thu, 13 Jun 2024 13:33:11 +0200 Message-ID: <20240613113311.270327688@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113302.116811394@linuxfoundation.org> References: <20240613113302.116811394@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chao Yu [ Upstream commit 29ed2b5dd521ce7c5d8466cd70bf0cc9d07afeee ] f2fs image may be corrupted after below testcase: - mkfs.f2fs -O extra_attr,compression -f /dev/vdb - mount /dev/vdb /mnt/f2fs - touch /mnt/f2fs/file - f2fs_io setflags compression /mnt/f2fs/file - dd if=/dev/zero of=/mnt/f2fs/file bs=4k count=4 - f2fs_io release_cblocks /mnt/f2fs/file - truncate -s 8192 /mnt/f2fs/file - umount /mnt/f2fs - fsck.f2fs /dev/vdb [ASSERT] (fsck_chk_inode_blk:1256) --> ino: 0x5 has i_blocks: 0x00000002, but has 0x3 blocks [FSCK] valid_block_count matching with CP [Fail] [0x4, 0x5] [FSCK] other corrupted bugs [Fail] The reason is: partial truncation assume compressed inode has reserved blocks, after partial truncation, valid block count may change w/o .i_blocks and .total_valid_block_count update, result in corruption. This patch only allow cluster size aligned truncation on released compress inode for fixing. Fixes: c61404153eb6 ("f2fs: introduce FI_COMPRESS_RELEASED instead of using IMMUTABLE bit") Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/file.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 30b015fbec6a5..be9536815e50d 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -899,9 +899,14 @@ int f2fs_setattr(struct user_namespace *mnt_userns, struct dentry *dentry, ATTR_GID | ATTR_TIMES_SET)))) return -EPERM; - if ((attr->ia_valid & ATTR_SIZE) && - !f2fs_is_compress_backend_ready(inode)) - return -EOPNOTSUPP; + if ((attr->ia_valid & ATTR_SIZE)) { + if (!f2fs_is_compress_backend_ready(inode)) + return -EOPNOTSUPP; + if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED) && + !IS_ALIGNED(attr->ia_size, + F2FS_BLK_TO_BYTES(F2FS_I(inode)->i_cluster_size))) + return -EINVAL; + } err = setattr_prepare(&init_user_ns, dentry, attr); if (err) -- 2.43.0