From: Greg KH <gregkh@linuxfoundation.org>
To: Po-Hsu Lin <po-hsu.lin@canonical.com>
Cc: stable@vger.kernel.org, petrm@nvidia.com, liuhangbin@gmail.com,
pabeni@redhat.com, kuba@kernel.org, bpoirier@nvidia.com,
idosch@nvidia.com
Subject: Re: [PATCHv3 6.6.y 0/3] Fix missing lib.sh for net/unicast_extensions.sh and net/pmtu.sh tests
Date: Wed, 19 Jun 2024 12:55:34 +0200 [thread overview]
Message-ID: <2024061921-prepay-upcoming-84db@gregkh> (raw)
In-Reply-To: <20240619093924.1291623-1-po-hsu.lin@canonical.com>
On Wed, Jun 19, 2024 at 05:39:21PM +0800, Po-Hsu Lin wrote:
> Since upstream commit:
> * 0f4765d0 "selftests/net: convert unicast_extensions.sh to run it in
> unique namespace"
> * 378f082e "selftests/net: convert pmtu.sh to run it in unique namespace"
>
> The lib.sh from commit 25ae948b "selftests/net: add lib.sh" will be needed.
> Otherwise these test will complain about missing files and fail:
> $ sudo ./unicast_extensions.sh
> ./unicast_extensions.sh: line 31: lib.sh: No such file or directory
> ...
>
> $ sudo ./pmtu.sh
> ./pmtu.sh: line 201: lib.sh: No such file or directory
> ./pmtu.sh: line 941: cleanup_all_ns: command not found
> ...
>
> Another commit b6925b4e "selftests/net: add variable NS_LIST for lib.sh" is
> needed to add support for the cleanup_all_ns above.
>
> And 2114e833 "selftests: forwarding: Avoid failures to source net/lib.sh" is
> a follow-up fix for tests inside the net/forwarding directory.
>
> V2: Add 2114e833 "selftests: forwarding: Avoid failures to source net/lib.sh"
> as suggested by Hangbin Liu.
> V3: Adjust commit 25ae948b to add lib.sh directly to TEST_FILES in Makefile,
> as we already have upstream commit 06efafd8 that would make this change
> landed in 6.6.y.
Thanks for the quick response, now queued up.
greg k-h
prev parent reply other threads:[~2024-06-19 10:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 9:39 [PATCHv3 6.6.y 0/3] Fix missing lib.sh for net/unicast_extensions.sh and net/pmtu.sh tests Po-Hsu Lin
2024-06-19 9:39 ` [PATCHv3 6.6.y 1/3] selftests/net: add lib.sh Po-Hsu Lin
2024-06-19 9:39 ` [PATCHv3 6.6.y 2/3] selftests/net: add variable NS_LIST for lib.sh Po-Hsu Lin
2024-06-19 9:39 ` [PATCHv3 6.6.y 3/3] selftests: forwarding: Avoid failures to source net/lib.sh Po-Hsu Lin
2024-06-19 10:55 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024061921-prepay-upcoming-84db@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bpoirier@nvidia.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=po-hsu.lin@canonical.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox