From: Greg KH <gregkh@linuxfoundation.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: stable@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Yang Shi <shy828301@gmail.com>,
Oscar Salvador <osalvador@suse.de>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Naoya Horiguchi <nao.horiguchi@gmail.com>,
Xu Yu <xuyu@linux.alibaba.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 5.15.y] mm/huge_memory: don't unpoison huge_zero_folio
Date: Wed, 19 Jun 2024 11:34:37 +0200 [thread overview]
Message-ID: <2024061928-basis-abdomen-bab7@gregkh> (raw)
In-Reply-To: <20240618032727.2389102-1-linmiaohe@huawei.com>
On Tue, Jun 18, 2024 at 11:27:27AM +0800, Miaohe Lin wrote:
> When I did memory failure tests recently, below panic occurs:
>
> kernel BUG at include/linux/mm.h:1135!
> invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
> CPU: 9 PID: 137 Comm: kswapd1 Not tainted 6.9.0-rc4-00491-gd5ce28f156fe-dirty #14
> RIP: 0010:shrink_huge_zero_page_scan+0x168/0x1a0
> RSP: 0018:ffff9933c6c57bd0 EFLAGS: 00000246
> RAX: 000000000000003e RBX: 0000000000000000 RCX: ffff88f61fc5c9c8
> RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff88f61fc5c9c0
> RBP: ffffcd7c446b0000 R08: ffffffff9a9405f0 R09: 0000000000005492
> R10: 00000000000030ea R11: ffffffff9a9405f0 R12: 0000000000000000
> R13: 0000000000000000 R14: 0000000000000000 R15: ffff88e703c4ac00
> FS: 0000000000000000(0000) GS:ffff88f61fc40000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 000055f4da6e9878 CR3: 0000000c71048000 CR4: 00000000000006f0
> Call Trace:
> <TASK>
> do_shrink_slab+0x14f/0x6a0
> shrink_slab+0xca/0x8c0
> shrink_node+0x2d0/0x7d0
> balance_pgdat+0x33a/0x720
> kswapd+0x1f3/0x410
> kthread+0xd5/0x100
> ret_from_fork+0x2f/0x50
> ret_from_fork_asm+0x1a/0x30
> </TASK>
> Modules linked in: mce_inject hwpoison_inject
> ---[ end trace 0000000000000000 ]---
> RIP: 0010:shrink_huge_zero_page_scan+0x168/0x1a0
> RSP: 0018:ffff9933c6c57bd0 EFLAGS: 00000246
> RAX: 000000000000003e RBX: 0000000000000000 RCX: ffff88f61fc5c9c8
> RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff88f61fc5c9c0
> RBP: ffffcd7c446b0000 R08: ffffffff9a9405f0 R09: 0000000000005492
> R10: 00000000000030ea R11: ffffffff9a9405f0 R12: 0000000000000000
> R13: 0000000000000000 R14: 0000000000000000 R15: ffff88e703c4ac00
> FS: 0000000000000000(0000) GS:ffff88f61fc40000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 000055f4da6e9878 CR3: 0000000c71048000 CR4: 00000000000006f0
>
> The root cause is that HWPoison flag will be set for huge_zero_folio
> without increasing the folio refcnt. But then unpoison_memory() will
> decrease the folio refcnt unexpectedly as it appears like a successfully
> hwpoisoned folio leading to VM_BUG_ON_PAGE(page_ref_count(page) == 0) when
> releasing huge_zero_folio.
>
> Skip unpoisoning huge_zero_folio in unpoison_memory() to fix this issue.
> We're not prepared to unpoison huge_zero_folio yet.
>
> Link: https://lkml.kernel.org/r/20240516122608.22610-1-linmiaohe@huawei.com
> Fixes: 478d134e9506 ("mm/huge_memory: do not overkill when splitting huge_zero_page")
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> Acked-by: David Hildenbrand <david@redhat.com>
> Reviewed-by: Yang Shi <shy828301@gmail.com>
> Reviewed-by: Oscar Salvador <osalvador@suse.de>
> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
> Cc: Naoya Horiguchi <nao.horiguchi@gmail.com>
> Cc: Xu Yu <xuyu@linux.alibaba.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> (cherry picked from commit fe6f86f4b40855a130a19aa589f9ba7f650423f4)
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/memory-failure.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
All now queued up, thanks!
greg k-h
prev parent reply other threads:[~2024-06-19 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 8:03 FAILED: patch "[PATCH] mm/huge_memory: don't unpoison huge_zero_folio" failed to apply to 5.15-stable tree gregkh
2024-06-18 3:27 ` [PATCH 5.15.y] mm/huge_memory: don't unpoison huge_zero_folio Miaohe Lin
2024-06-19 9:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024061928-basis-abdomen-bab7@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=nao.horiguchi@gmail.com \
--cc=osalvador@suse.de \
--cc=shy828301@gmail.com \
--cc=stable@vger.kernel.org \
--cc=xuyu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox