public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Joel Granados <j.granados@samsung.com>
Cc: stable@vger.kernel.org, stable-commits@vger.kernel.org,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	Jozsef Kadlecsik <kadlec@netfilter.org>,
	Roopa Prabhu <roopa@nvidia.com>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	David Ahern <dsahern@kernel.org>,
	Simon Horman <horms@verge.net.au>, Julian Anastasov <ja@ssi.bg>
Subject: Re: Patch "netfilter: Remove the now superfluous sentinel elements from ctl_table array" has been added to the 6.6-stable tree
Date: Mon, 24 Jun 2024 16:55:26 +0200	[thread overview]
Message-ID: <2024062407-convene-imperfect-6c22@gregkh> (raw)
In-Reply-To: <20240624071005.tnijkj7b36bvztks@joelS2.panther.com>

On Mon, Jun 24, 2024 at 09:10:05AM +0200, Joel Granados wrote:
> On Sat, Jun 22, 2024 at 07:45:37PM -0400, Sasha Levin wrote:
> > This is a note to let you know that I've just added the patch titled
> > 
> >     netfilter: Remove the now superfluous sentinel elements from ctl_table array
> > 
> > to the 6.6-stable tree which can be found at:
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > 
> > The filename of the patch is:
> >      netfilter-remove-the-now-superfluous-sentinel-elemen.patch
> > and it can be found in the queue-6.6 subdirectory.
> > 
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> 
> I don't understand why we are putting these in stable. IMO, they should
> not go there and this is why:
> 
> 1. This is not a fix.
>    The main motivation for doing these sentinel removals is to avoid
>    bloat in the boot and compiled image (read more in cover letters for
>    [1,2,3,4,5,6]) in future kernel versions. This makes no sense in
>    stable IMO.
> 
> 2. There are lots of moving parts and no "bang for the buck"
>    If you are going to bring one of them, you need to bring all of them.
>    This means brining in the preparation [7], the intermediate
>    [1,2,3,4,5,6] and the final patch [8]. This is not only prone to
>    error, but there is no real reason to do that in stable.
> 
> If I'm missing something, please let me know.

This was needed for the patch following this in the series.  I fixed
that one up by hand and dropped this one now, thanks.

greg k-h

      reply	other threads:[~2024-06-24 14:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240622234558eucas1p2a6211f0643e368f34541573847b7105e@eucas1p2.samsung.com>
     [not found] ` <20240622234538.197608-1-sashal@kernel.org>
2024-06-24  7:10   ` Patch "netfilter: Remove the now superfluous sentinel elements from ctl_table array" has been added to the 6.6-stable tree Joel Granados
2024-06-24 14:55     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024062407-convene-imperfect-6c22@gregkh \
    --to=greg@kroah.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@verge.net.au \
    --cc=j.granados@samsung.com \
    --cc=ja@ssi.bg \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=razor@blackwall.org \
    --cc=roopa@nvidia.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox