Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Wentong Wu <wentong.wu@intel.com>
To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com,
	gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, Wentong Wu <wentong.wu@intel.com>,
	stable@vger.kernel.org, Jason Chen <jason.z.chen@intel.com>
Subject: [PATCH v3 4/5] mei: vsc: Prevent timeout error with added delay post-firmware download
Date: Mon, 24 Jun 2024 21:28:48 +0800	[thread overview]
Message-ID: <20240624132849.4174494-5-wentong.wu@intel.com> (raw)
In-Reply-To: <20240624132849.4174494-1-wentong.wu@intel.com>

After completing the firmware download, the firmware requires some
time to become functional. This change introduces additional sleep
time before the first read operation to prevent a confusing timeout
error in vsc_tp_xfer().

Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device")
Cc: stable@vger.kernel.org # for 6.8+
Signed-off-by: Wentong Wu <wentong.wu@intel.com>
Tested-by: Jason Chen <jason.z.chen@intel.com>
---
 drivers/misc/mei/platform-vsc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/mei/platform-vsc.c b/drivers/misc/mei/platform-vsc.c
index 1ec65d87488a..d02f6e881139 100644
--- a/drivers/misc/mei/platform-vsc.c
+++ b/drivers/misc/mei/platform-vsc.c
@@ -28,8 +28,8 @@
 
 #define MEI_VSC_MAX_MSG_SIZE		512
 
-#define MEI_VSC_POLL_DELAY_US		(50 * USEC_PER_MSEC)
-#define MEI_VSC_POLL_TIMEOUT_US		(200 * USEC_PER_MSEC)
+#define MEI_VSC_POLL_DELAY_US		(100 * USEC_PER_MSEC)
+#define MEI_VSC_POLL_TIMEOUT_US		(400 * USEC_PER_MSEC)
 
 #define mei_dev_to_vsc_hw(dev)		((struct mei_vsc_hw *)((dev)->hw))
 
-- 
2.34.1


      parent reply	other threads:[~2024-06-24 13:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240624132849.4174494-1-wentong.wu@intel.com>
2024-06-24 13:28 ` [PATCH v3 1/5] mei: vsc: Enhance IVSC chipset stability during warm reboot Wentong Wu
2024-06-24 13:28 ` [PATCH v3 2/5] mei: vsc: Enhance SPI transfer of IVSC rom Wentong Wu
2024-06-24 14:29   ` Winkler, Tomas
2024-06-24 13:28 ` [PATCH v3 3/5] mei: vsc: Utilize the appropriate byte order swap function Wentong Wu
2024-06-24 13:28 ` Wentong Wu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240624132849.4174494-5-wentong.wu@intel.com \
    --to=wentong.wu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jason.z.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=stable@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox