From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wfhigh2-smtp.messagingengine.com (wfhigh2-smtp.messagingengine.com [64.147.123.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2871B2D600; Tue, 25 Jun 2024 05:42:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.123.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719294172; cv=none; b=iGozrqlxBR6aQuxmrkv5lUE7guhcNOdR4vxXZUuplC+POhFC80D6Ej/MjwXz9Fxhw32yHJ9IdgI0KdDiXuU9hWfjtIf4GY8SaRiUkfsXlZVeYojQ6BeHPISXGTOGjquQ9an2Mn+WUhKopxgmHwwMITESBU0qGlrS/HZzQjzV++Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719294172; c=relaxed/simple; bh=pMtLjxJAUVQSXjC7H8x3xJNeofOdmXKNPJMn1qX/nC0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L7YvUy7lY2pqzYprePUVrdlX/+DMEdqlqYqhh/+V/kIFBf9UNLkk+sMhk+kKF2e/Z9AARHzjIIxWumcMTaMgOxOIZQWZ1dDGI7H8QCA0HGHRhjvoIgHwCU4tKFOLrMZeNK0nh2/cqICyKf3jnTbqgvEhi4eeoiMlKefiq3HQhjM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kroah.com; spf=pass smtp.mailfrom=kroah.com; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b=rh7evAJw; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=MmnmRnDw; arc=none smtp.client-ip=64.147.123.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kroah.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kroah.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="rh7evAJw"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="MmnmRnDw" Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.west.internal (Postfix) with ESMTP id 60293180028E; Tue, 25 Jun 2024 01:42:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 25 Jun 2024 01:42:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1719294168; x=1719380568; bh=tNFJMSSYvl qtPJ4Jq6knqUseKigf4JmQ6vFlQUE+I08=; b=rh7evAJwRZUWwzR6qpC0CPW5TH BRRPWRfNiMnxj9/Vj+1Wrf0Qs5h5Gc1hAgwf4uRVXE+s9+aoK0dAc2SvPNqOI79D V1bOJ5ObCNC/DAuSomeHXnER8oKXUnPqj3NJux/i1NUVTQLiH1dJIYrcimcUHeqk jAGmXk/2Wigdewcs4xgdf1JeaDpWFRcFxZr/mkenWDwdvnIip+eBUO7n2QeiWEPs xjPcUBG83mb9n6djxpzcRoEEcjorn8gTQgh99stksCRGdpkV+rkKsKAq6tCcKEhX C2tDvz3bVvmxJdu7vLzS71Y0R8jOpMc3WAHNXkysjZqHTmF9N795e3WAtYbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1719294168; x=1719380568; bh=tNFJMSSYvlqtPJ4Jq6knqUseKigf 4JmQ6vFlQUE+I08=; b=MmnmRnDwRiEpfHe3IRsXW0BWcZvEt4LGPsisFeos3ljT sLGG0PN/hHET2TGWZ4orWi/sB94LVTX/GtnpsSTtKymU7a4L5Umt7EEDjq7rBLYR SEWFevQDlJGjgFPLs3UCEPyn0e4zGjQ7wnRuk3GfPkE8cSKYJ95jU3e6R3k8s18w gTf+erwjtFRZoGBp+dqklR5qxinIfIleDittTg18wCNHtBh+GCMztuC4AFfg3LMA NTI9lCAmpu2p31qGss5WD6HdSSw5U/Mpm17S07zKHJNVYq8JbLbAZhGDluKz7jvb 16OTSdo5cgfjzDVVW9A44S5lGRDHVVybQD0X+b+w2w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeegvddguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgv ghcumffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeeghe euhefgtdeluddtleekfeegjeetgeeikeehfeduieffvddufeefleevtddtvdenucffohhm rghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhm X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Jun 2024 01:42:46 -0400 (EDT) Date: Tue, 25 Jun 2024 07:42:44 +0200 From: Greg KH To: NeilBrown Cc: stable@vger.kernel.org, stable-commits@vger.kernel.org, jlayton@kernel.org, Trond Myklebust , Anna Schumaker , Chuck Lever , Olga Kornievskaia , Dai Ngo , Tom Talpey , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: Patch "nfsd: fix oops when reading pool_stats before server is started" has been added to the 6.9-stable tree Message-ID: <2024062537-overtone-cupping-3f13@gregkh> References: <20240624134957.936227-1-sashal@kernel.org> <171926974436.14261.14452569082069214699@noble.neil.brown.name> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <171926974436.14261.14452569082069214699@noble.neil.brown.name> On Tue, Jun 25, 2024 at 08:55:44AM +1000, NeilBrown wrote: > On Mon, 24 Jun 2024, stable@vger.kernel.org wrote: > > This is a note to let you know that I've just added the patch titled > > > > nfsd: fix oops when reading pool_stats before server is started > > > > to the 6.9-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > The filename of the patch is: > > nfsd-fix-oops-when-reading-pool_stats-before-server-.patch > > and it can be found in the queue-6.9 subdirectory. > > > > If you, or anyone else, feels it should not be added to the stable tree, > > please let know about it. > > I feel this should not be added to the stable tree. > > It moves at test on a field protected by a mutex outside of the > protection of that mutex, and so is obviously racey. > > Depending on how the race goes, si->serv might be NULL when dereferenced > in svc_pool_stats_start(), or svc_pool_stats_stop() might unlock a mutex > that hadn't been locked. > > I'll post a revert and a better fix for mainline. Now dropped, thanks! greg k-h