From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFC94173335; Wed, 3 Jul 2024 10:44:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720003444; cv=none; b=WlX9UygP27LgT+FlRBaFFBFsV8n3iGTwp5RpumUEqr8TnUjCVY0aAiPdAMXZyg/vwoI48Sf2zpQ8k/ex95gJL9/hsSzLalxx8eCXkhF+fiQ1KNgoB3K4i/XLixpDdhuPRH2b/ibOgqPAiLwTs+Ahs2j7T5R+oNCfNcmO9o2exZs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720003444; c=relaxed/simple; bh=TvvRUbZl5Va76HI1a6PQRiTz4QPwDceBeQSLMIHsZFg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=H4YdnIWIf9EEUX/s1fHwMWpIm4jad1C7bPtfOpjJxYKAgNGADlEGUWFH+9ZOBd4seGREOGJoktv6TyJ7FmKzfQdnkqoPgE/90GphPmWjVddEdOHtWcjuZqkwW6cYeffKc2sUU86DbcmHe9mg2ifl++RE6YgbB1yautheSqno6Xw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=N2eIdvj8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="N2eIdvj8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3593EC2BD10; Wed, 3 Jul 2024 10:44:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720003444; bh=TvvRUbZl5Va76HI1a6PQRiTz4QPwDceBeQSLMIHsZFg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N2eIdvj8Ei49b3StTdAlYdAMsrDlxZmBVKe8rGVzWvmawJ/UtdFJjDwYxgvKO61wc OylSJ3pmn5XRHtnZeA2iwCPhxC7Lb7EA0pPVrKwuxbpK8jK+a/R2f2QXoplMNPVo0x iVmosr3q9K5AqBl7CkkkP8cpAuhxwxFW/4YAkCC8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Rick Wertenbroek , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Bjorn Helgaas , Damien Le Moal Subject: [PATCH 4.19 050/139] PCI: rockchip-ep: Remove wrong mask on subsys_vendor_id Date: Wed, 3 Jul 2024 12:39:07 +0200 Message-ID: <20240703102832.325800924@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240703102830.432293640@linuxfoundation.org> References: <20240703102830.432293640@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Rick Wertenbroek commit 2dba285caba53f309d6060fca911b43d63f41697 upstream. Remove wrong mask on subsys_vendor_id. Both the Vendor ID and Subsystem Vendor ID are u16 variables and are written to a u32 register of the controller. The Subsystem Vendor ID was always 0 because the u16 value was masked incorrectly with GENMASK(31,16) resulting in all lower 16 bits being set to 0 prior to the shift. Remove both masks as they are unnecessary and set the register correctly i.e., the lower 16-bits are the Vendor ID and the upper 16-bits are the Subsystem Vendor ID. This is documented in the RK3399 TRM section 17.6.7.1.17 [kwilczynski: removed unnecesary newline] Fixes: cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller") Link: https://lore.kernel.org/linux-pci/20240403144508.489835-1-rick.wertenbroek@gmail.com Signed-off-by: Rick Wertenbroek Signed-off-by: Krzysztof Wilczyński Signed-off-by: Bjorn Helgaas Reviewed-by: Damien Le Moal Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/pci/controller/pcie-rockchip-ep.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/drivers/pci/controller/pcie-rockchip-ep.c +++ b/drivers/pci/controller/pcie-rockchip-ep.c @@ -130,10 +130,8 @@ static int rockchip_pcie_ep_write_header /* All functions share the same vendor ID with function 0 */ if (fn == 0) { - u32 vid_regs = (hdr->vendorid & GENMASK(15, 0)) | - (hdr->subsys_vendor_id & GENMASK(31, 16)) << 16; - - rockchip_pcie_write(rockchip, vid_regs, + rockchip_pcie_write(rockchip, + hdr->vendorid | hdr->subsys_vendor_id << 16, PCIE_CORE_CONFIG_VENDOR); }