From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78ADB173352; Wed, 3 Jul 2024 10:46:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720003589; cv=none; b=pUK4EgZmLFIsrcBNONKfQMAm0kcDsFhJ7N2qyb22Ja8dsXr2FuRKkF9sc02thJaA96ceypxRVlnkbWbJLwKz5l2HG87eokmU271W40REfOKPaTVEktzCZ7tVx3VISjDiyah/9mU1E3L5f1oQGfoUWgQUQ+DWh/I/O4vrC3uxbXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720003589; c=relaxed/simple; bh=x6tmNgTs9rX2om8Loty7Uvra1t1Aw7GIrYheB/JLBr4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VLkDWoBk2784NqR0J41MIhOtsZ59vqS+WEuue0yOQzzMc6d0dmOj6q7tilj8AVAWhYoG5ZHrkiouMAMcW3Zq6VOesX/cRzZ3eQc8bK9+JgsU7MQosb1UTBg5RdQwCi+1oc06Cd8vzatHeYANObH0tTxcH4xZPZFehxNzrl0vA6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=o0eUi+RH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="o0eUi+RH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8B54C2BD10; Wed, 3 Jul 2024 10:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720003589; bh=x6tmNgTs9rX2om8Loty7Uvra1t1Aw7GIrYheB/JLBr4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o0eUi+RHvXXsQtDBgndmxVQ7WvIU3k5vdqzxAgU4kMZylQU1CAclACsB/vgZC2VbR YwRV7++ii39lZ56vWXinQDOgaSXBQTjyfD/QeE1SHpfLMwYK2SBACoB3YvRwmR6ljl yFKqj2Z3NclvwouA7OuGisP2Cpffd/Rn9MncpltE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Maximilian Heyne , Hagar Hemdan , Linus Walleij , Sasha Levin Subject: [PATCH 4.19 099/139] pinctrl: fix deadlock in create_pinctrl() when handling -EPROBE_DEFER Date: Wed, 3 Jul 2024 12:39:56 +0200 Message-ID: <20240703102834.180012410@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240703102830.432293640@linuxfoundation.org> References: <20240703102830.432293640@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hagar Hemdan [ Upstream commit adec57ff8e66aee632f3dd1f93787c13d112b7a1 ] In create_pinctrl(), pinctrl_maps_mutex is acquired before calling add_setting(). If add_setting() returns -EPROBE_DEFER, create_pinctrl() calls pinctrl_free(). However, pinctrl_free() attempts to acquire pinctrl_maps_mutex, which is already held by create_pinctrl(), leading to a potential deadlock. This patch resolves the issue by releasing pinctrl_maps_mutex before calling pinctrl_free(), preventing the deadlock. This bug was discovered and resolved using Coverity Static Analysis Security Testing (SAST) by Synopsys, Inc. Fixes: 42fed7ba44e4 ("pinctrl: move subsystem mutex to pinctrl_dev struct") Suggested-by: Maximilian Heyne Signed-off-by: Hagar Hemdan Link: https://lore.kernel.org/r/20240604085838.3344-1-hagarhem@amazon.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 052894d3a2047..97b1fa3a5e78d 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -1078,8 +1078,8 @@ static struct pinctrl *create_pinctrl(struct device *dev, * an -EPROBE_DEFER later, as that is the worst case. */ if (ret == -EPROBE_DEFER) { - pinctrl_free(p, false); mutex_unlock(&pinctrl_maps_mutex); + pinctrl_free(p, false); return ERR_PTR(ret); } } -- 2.43.0