From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36EFB174EFC; Wed, 3 Jul 2024 10:48:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720003725; cv=none; b=ESITh03dZE9VzESpvwTvWjv2nCUKwbbP0bJcp7fLaaN0725vJoewZCeNiTQA1yXkx4ZOWu7KnX+CsOacqmOr8crY3JbQxb9sTzwaWYkmAGpzmIXs1OTf7W1ZZMIFnIUPwJ9L+aS5yRBfjDhcgyAb8EbaumTzpLDO5ibtWYigM1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720003725; c=relaxed/simple; bh=qH7OyztJBtCabDMQINNrxBWxLuejXGuTypRibpjXxQc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JhWIikHR6KLgm3Gem18xH8Qzh4AorteAkFXs61Isz6G55WotlYqhVAmPiOQl4ruqO4ipU/ZCHbLrxhxzfwoJoviehQHWsqg0imZXlDC1RBfUcuHH4bWQrb/rSf4cUdSshN6oRUOzm+dqXcPsaHf7+rROZF+RNqgW0obyVaG3tiU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WPomfrC6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WPomfrC6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB7B9C2BD10; Wed, 3 Jul 2024 10:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720003725; bh=qH7OyztJBtCabDMQINNrxBWxLuejXGuTypRibpjXxQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WPomfrC6/tg3nguSKrZXl78fojXQbtiY9GIUtfJ5bAZ3zdOdn7swm1fFVcKoCTirv gsNFqc2/+psygFz0d4uZvVw03Xv0LbbgPmj6oagudXzRjDAYvvYM4vsHQ2MNFs3kJg tYfn8PsW3v+zlwhr8kyAHOuiY6fiV3TlBTaJm8mM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Stefan Eichenberger Subject: [PATCH 4.19 127/139] serial: imx: set receiver level before starting uart Date: Wed, 3 Jul 2024 12:40:24 +0200 Message-ID: <20240703102835.232203187@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240703102830.432293640@linuxfoundation.org> References: <20240703102830.432293640@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stefan Eichenberger commit a81dbd0463eca317eee44985a66aa6cc2ce5c101 upstream. Set the receiver level to something > 0 before calling imx_uart_start_rx in rs485_config. This is necessary to avoid an interrupt storm that might prevent the system from booting. This was seen on an i.MX7 device when the rs485-rts-active-low property was active in the device tree. Fixes: 6d215f83e5fc ("serial: imx: warn user when using unsupported configuration") Cc: stable Signed-off-by: Stefan Eichenberger Link: https://lore.kernel.org/r/20240621153829.183780-1-eichest@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/imx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -1860,8 +1860,10 @@ static int imx_uart_rs485_config(struct /* Make sure Rx is enabled in case Tx is active with Rx disabled */ if (!(rs485conf->flags & SER_RS485_ENABLED) || - rs485conf->flags & SER_RS485_RX_DURING_TX) + rs485conf->flags & SER_RS485_RX_DURING_TX) { + imx_uart_setup_ufcr(sport, TXTL_DEFAULT, RXTL_DEFAULT); imx_uart_start_rx(port); + } port->rs485 = *rs485conf;