From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB155188CDA; Wed, 3 Jul 2024 10:56:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720004208; cv=none; b=dxsTboHm4U+x1ZNW0qc08mVR7+ZaH7JoQPwpnTMnRUZScOicIyusX8i6YiP85aJcxP69p+kUsuO50GCCgwkzsxjAuf+cTUFdmrH4Ett+4e1OVNMjng50032jVo9oMkUTg7T0FBCqYk366Qv8CbwdVauKcGlk5nal9nx7AU4BuXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720004208; c=relaxed/simple; bh=cR4A/dKs8UeXWonsDHuo5zIp8GGCIuLHp+AuSJrlcDA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SfPCdH/h7+3jM9uMJptkVk8IAy4MNwnmOzIpWtSCgC7Iyd4RaezY0RdmRfeXKujxXSgdoCMebA4bSsc9A7CkjHELnZqYGdA43XnfplN2V9afB/hX7rP4TLJMOTSpsJIDBEaMRGHt1dJpSy1HiEB0d4BExsrvFUdj1tTrl4Y4C08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hu3X5yao; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hu3X5yao" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F868C2BD10; Wed, 3 Jul 2024 10:56:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720004208; bh=cR4A/dKs8UeXWonsDHuo5zIp8GGCIuLHp+AuSJrlcDA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hu3X5yaoKhvdrBK+O0OxR1Lah6MSsjGRpXkG9O1W8ikqKkMdAa6xW1sCQg+ezX+nN 0BtS5oWdKrU5mmBzwyOze6HKUSuvvlXCGGc2Tdlq3i3VvbqkEgGOL2olC9uaM2QUmr KDrJcyZvjRs0cVGqfwXWOdgayfI3Qv42Hmd2u6Yc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Aleksandr Mishin , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 5.4 155/189] gpio: davinci: Validate the obtained number of IRQs Date: Wed, 3 Jul 2024 12:40:16 +0200 Message-ID: <20240703102847.321002428@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240703102841.492044697@linuxfoundation.org> References: <20240703102841.492044697@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aleksandr Mishin [ Upstream commit 7aa9b96e9a73e4ec1771492d0527bd5fc5ef9164 ] Value of pdata->gpio_unbanked is taken from Device Tree. In case of broken DT due to any error this value can be any. Without this value validation there can be out of chips->irqs array boundaries access in davinci_gpio_probe(). Validate the obtained nirq value so that it won't exceed the maximum number of IRQs per bank. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: eb3744a2dd01 ("gpio: davinci: Do not assume continuous IRQ numbering") Signed-off-by: Aleksandr Mishin Link: https://lore.kernel.org/r/20240618144344.16943-1-amishin@t-argos.ru Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-davinci.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index 576cb2d0708f6..ae5c3080ec3c1 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -227,6 +227,11 @@ static int davinci_gpio_probe(struct platform_device *pdev) else nirq = DIV_ROUND_UP(ngpio, 16); + if (nirq > MAX_INT_PER_BANK) { + dev_err(dev, "Too many IRQs!\n"); + return -EINVAL; + } + chips = devm_kzalloc(dev, sizeof(*chips), GFP_KERNEL); if (!chips) return -ENOMEM; -- 2.43.0