From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94110187554; Wed, 3 Jul 2024 10:56:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720004215; cv=none; b=X9BUs23qqid4mXPALIPSW2yVndWvsleX7PhpRWdyUcJ0KN4Z6EyGDmb+aBoqi3oADiHSfYWgMWQwLjZmuEJd/qB2QiqU89v+392lr8s3u/USYT4ngxw6Dg87dycoRJdyMJVChXLA7K1yMGymvYsyb2lgPZeKbWNKwXu67vtCS9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720004215; c=relaxed/simple; bh=AMlyiqLoVfvDd0k1xDnH8K+WHJHy3uhrcmVDhyU0TtM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=crasYohHCTtfykZOITTG+/VCYJKRh8HYIbXiP3FJT3614OJ3PaVFnRUx1TJU+SoA/Cd4v9GlxvOo3i1NH9vbFgKXqj8RS9EVOZrAnsYhWkuUm4bq767tix7+HDoIi/Ay1NhTX+9YsIDVgpizX1ZP1PqfAGjbfCN2rBukuBvi4os= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QQmRVjEm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QQmRVjEm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C203C4AF0C; Wed, 3 Jul 2024 10:56:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720004215; bh=AMlyiqLoVfvDd0k1xDnH8K+WHJHy3uhrcmVDhyU0TtM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QQmRVjEmUQaBXe2+CJHvBTwG4+YZYUhAWMxWa8G4Cr2RdgM0S2ZdhGaG10LSZSWRc ZcEf+QQZo1TzhLqVAT8y6yRMEb6GNaf6giCE2VayUFftl42uaBZHg5/XO0zTYfHZ0y lo6KRfDEdpAroeYGAb2Aq2md9x+rMSAmSR4uepeM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Adrian Hunter , Ulf Hansson Subject: [PATCH 5.4 157/189] mmc: sdhci-pci: Convert PCIBIOS_* return codes to errnos Date: Wed, 3 Jul 2024 12:40:18 +0200 Message-ID: <20240703102847.395262549@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240703102841.492044697@linuxfoundation.org> References: <20240703102841.492044697@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ilpo Järvinen commit ebc4fc34eae8ddfbef49f2bdaced1bf4167ef80d upstream. jmicron_pmos() and sdhci_pci_probe() use pci_{read,write}_config_byte() that return PCIBIOS_* codes. The return code is then returned as is by jmicron_probe() and sdhci_pci_probe(). Similarly, the return code is also returned as is from jmicron_resume(). Both probe and resume functions should return normal errnos. Convert PCIBIOS_* returns code using pcibios_err_to_errno() into normal errno before returning them the fix these issues. Fixes: 7582041ff3d4 ("mmc: sdhci-pci: fix simple_return.cocci warnings") Fixes: 45211e215984 ("sdhci: toggle JMicron PMOS setting") Cc: stable@vger.kernel.org Signed-off-by: Ilpo Järvinen Acked-by: Adrian Hunter Link: https://lore.kernel.org/r/20240527132443.14038-1-ilpo.jarvinen@linux.intel.com Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/host/sdhci-pci-core.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) --- a/drivers/mmc/host/sdhci-pci-core.c +++ b/drivers/mmc/host/sdhci-pci-core.c @@ -1376,7 +1376,7 @@ static int jmicron_pmos(struct sdhci_pci ret = pci_read_config_byte(chip->pdev, 0xAE, &scratch); if (ret) - return ret; + goto fail; /* * Turn PMOS on [bit 0], set over current detection to 2.4 V @@ -1387,7 +1387,10 @@ static int jmicron_pmos(struct sdhci_pci else scratch &= ~0x47; - return pci_write_config_byte(chip->pdev, 0xAE, scratch); + ret = pci_write_config_byte(chip->pdev, 0xAE, scratch); + +fail: + return pcibios_err_to_errno(ret); } static int jmicron_probe(struct sdhci_pci_chip *chip) @@ -2303,7 +2306,7 @@ static int sdhci_pci_probe(struct pci_de ret = pci_read_config_byte(pdev, PCI_SLOT_INFO, &slots); if (ret) - return ret; + return pcibios_err_to_errno(ret); slots = PCI_SLOT_INFO_SLOTS(slots) + 1; dev_dbg(&pdev->dev, "found %d slot(s)\n", slots); @@ -2312,7 +2315,7 @@ static int sdhci_pci_probe(struct pci_de ret = pci_read_config_byte(pdev, PCI_SLOT_INFO, &first_bar); if (ret) - return ret; + return pcibios_err_to_errno(ret); first_bar &= PCI_SLOT_INFO_FIRST_BAR_MASK;