From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1440C1AAE30; Thu, 4 Jul 2024 09:28:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720085329; cv=none; b=fMyPJfZX5zxuMdYc0RRbVPj4EKoTj1fVrFy3qqPS5CoCj6qBpHS23NCugLigT+3lWE9c9Ap2onJAwqB6D9khagzOHhGoxJw3pFzKqdioHC61vNX0L3LqzqNdrs4UVxHSc2dh0N0UNghja86PFN5qRKa85BRW1hBIwS3eh5mBCZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720085329; c=relaxed/simple; bh=oS+6t3Gsu4be78gBFOPE2qryAV76MpPYFZGZKkhajYU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XnjsUMxGfEANDu48S1ol+kYZBgQs2qt+T5v3mrMKtdkLfaAMK1Vcl3bl/6TXGBL/1ObqWsa/LKKcXgpoxl5/1q0DRqgS4DmAia9XxSRDcaVTtjzYKeAJyZKxKVBkc9SAwXJUmqj2HW0W/+tOLV07T9n/X7DMG8Al9WpcCnJ2O4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1cxZnEGH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1cxZnEGH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B5FCC3277B; Thu, 4 Jul 2024 09:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720085328; bh=oS+6t3Gsu4be78gBFOPE2qryAV76MpPYFZGZKkhajYU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1cxZnEGHbBMMYAiEy4pBFI8juo+Eim1Z4WLyS+N8B+uNO49MKbpLMtKjaJEz97SKn 6zuFfPgmP9NWfp5TIyezxFz/VAZebEiObvabqdGiPJ971GCjIPa34Tkw4C98DRspFg ZQq2QktXSyt+kweSK4xK92TwZGobzwmrOIwcsGsU= Date: Thu, 4 Jul 2024 11:19:12 +0200 From: Greg Kroah-Hartman To: Mark Brown Cc: stable@vger.kernel.org, patches@lists.linux.dev, Muhammad Usama Anjum , Ryan Roberts , Shuah Khan , Andrew Morton , Sasha Levin Subject: Re: [PATCH 5.15 067/356] selftests/mm: log a consistent test name for check_compaction Message-ID: <2024070405-tackiness-spiffy-9c18@gregkh> References: <20240703102913.093882413@linuxfoundation.org> <20240703102915.636328702@linuxfoundation.org> <416ea8e5-f3e0-47b3-93c2-34a67c474d8f@sirena.org.uk> <2024070349-convent-quiver-dc57@gregkh> <2a39df32-73ea-43fe-84ba-e840ba3dc835@sirena.org.uk> <2024070406-reformer-panning-20f2@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2024070406-reformer-panning-20f2@gregkh> On Thu, Jul 04, 2024 at 11:15:34AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 03, 2024 at 02:36:56PM +0100, Mark Brown wrote: > > On Wed, Jul 03, 2024 at 02:52:14PM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Jul 03, 2024 at 01:02:18PM +0100, Mark Brown wrote: > > > > On Wed, Jul 03, 2024 at 12:36:43PM +0200, Greg Kroah-Hartman wrote: > > > > > > > Refactor the logging to use a consistent name when printing the result of > > > > > the test, printing the existing messages as diagnostic information instead > > > > > so they are still available for people trying to interpret the results. > > > > > > I'm not convinced that this is a good stable candidate, it will change > > > > the output people are seeing in their test environment which might be an > > > > undesirable change. > > > > > Did it change the output in a breaking way in the other stable trees and > > > normal releases that happened with this commit in it? > > > > Yes, it'd affect other releases - I didn't notice it going into other > > stables (I tend to review the AUTOSEL stuff a lot more carefully than > > things you send out since you normally only pick things that are Cc > > stable but AUTOSEL has some wild stuff). The output tended to be stable > > for a given test setup so it's likely that if you're just looking for > > the same test results in a stable release you'd see these tests getting > > renamed on you. > > This is here as a dependency of another change, let me see if I can > remove it and get the dependant patch still working... Got it working, now dropped, thanks. greg k-h