From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D19BE156238; Tue, 9 Jul 2024 11:30:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720524609; cv=none; b=Vx43gbKbpVzXDEvWylsPHUGgt2Xxh1Y2SmHaiePGO7HdApfHj0sVF8xfJStBcyiMl/Ko1MqpH74pzYjwhU9K6vS+8M2N3LWvv3K6eUkt0cyyBR/0FWEhu8juFObJQ7L6E+gS/JEF+nA5200tj3G26dTh688VVzX7Z3qYV/SpzWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720524609; c=relaxed/simple; bh=oW8I041gOQhC2HME2emUUfI5P108Qo3qTtozo8vV8qE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WJzu8qjBRG45C8kaFV7nVl3s6UYs3kfUyYS/AhuB79cETzaG+ZZwdsyzJCVUA7LZC29sfu+BJgkWWl9Cf93nT0eZiW4V/rY50IThqoP6k2cJZwtYCCmFBLbQMC0xjGTh6tJ8kl+lQxGT4/fTfD120LaNr1RQdx5uGFQXGyOngFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VZufCS3y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VZufCS3y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11B53C3277B; Tue, 9 Jul 2024 11:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720524609; bh=oW8I041gOQhC2HME2emUUfI5P108Qo3qTtozo8vV8qE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VZufCS3yxa1oU55FBJf7i2z4oMqqN4ywXiWSPXgC5MrCMwz3zZ6kyQhwBrAcPEqiW Vg38x12N7k7ZXVJEjzWNzQ/3fFEUr5ANg7PZY+JRvm6P0swFb+jtqeuymypOwiHC1i wfSEpsel4t+Y060XDQn1Wfr6u3NX4yqRENDCKC48= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Heiko Carstens , Harald Freudenberger , Ingo Franzki , Holger Dengler , Alexander Gordeev , Sasha Levin Subject: [PATCH 6.1 040/102] s390/pkey: Wipe sensitive data on failure Date: Tue, 9 Jul 2024 13:10:03 +0200 Message-ID: <20240709110652.934440452@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240709110651.353707001@linuxfoundation.org> References: <20240709110651.353707001@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Holger Dengler [ Upstream commit 1d8c270de5eb74245d72325d285894a577a945d9 ] Wipe sensitive data from stack also if the copy_to_user() fails. Suggested-by: Heiko Carstens Reviewed-by: Harald Freudenberger Reviewed-by: Ingo Franzki Acked-by: Heiko Carstens Signed-off-by: Holger Dengler Signed-off-by: Alexander Gordeev Signed-off-by: Sasha Levin --- drivers/s390/crypto/pkey_api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s390/crypto/pkey_api.c b/drivers/s390/crypto/pkey_api.c index df0f19e6d9235..17885c9f55cb2 100644 --- a/drivers/s390/crypto/pkey_api.c +++ b/drivers/s390/crypto/pkey_api.c @@ -1191,7 +1191,7 @@ static long pkey_unlocked_ioctl(struct file *filp, unsigned int cmd, if (rc) break; if (copy_to_user(ucs, &kcs, sizeof(kcs))) - return -EFAULT; + rc = -EFAULT; memzero_explicit(&kcs, sizeof(kcs)); break; } @@ -1223,7 +1223,7 @@ static long pkey_unlocked_ioctl(struct file *filp, unsigned int cmd, if (rc) break; if (copy_to_user(ucp, &kcp, sizeof(kcp))) - return -EFAULT; + rc = -EFAULT; memzero_explicit(&kcp, sizeof(kcp)); break; } -- 2.43.0