From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3773555E4C; Tue, 9 Jul 2024 11:33:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720524786; cv=none; b=anx5XHgkiXABQJ9U91+bn5g82+va/OCPF7ZBx4+u674lbnSvQDmiQtSRpkpjph4IjfFb25Q1ZdYHey+CwYnV0Ty7H16ot4/eWtG1Y7G+nvcVX2m/8AOsW1nUV8Xhh99lm+oD3ussPQuoC66F+M5pfW8L/L6SNvT1B6IBylcEOKQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720524786; c=relaxed/simple; bh=j2rDYRqVT58/BQT5C+BJfvsaS+QsgZH7qTnKXerJrjA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oSe98TJ1w4FljULlDkTlVrWOXarBMpFrdFv61IGeniVnCgHmdHlul/zSXnYddnJzF0NZiOupwe6x+5V4DSWZUZ29LiZ+lIiZaV8phfm282wLVvfb4YCCy79hdNkU+uduJcpuYDLDo0O0LJe+prkzj62XlbTv/+wM1JCPgKV4ZmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=w2emV+dw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="w2emV+dw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE752C3277B; Tue, 9 Jul 2024 11:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720524786; bh=j2rDYRqVT58/BQT5C+BJfvsaS+QsgZH7qTnKXerJrjA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=w2emV+dwamW9x5uR3PzLOfris3RQcn5niAgak1o3pF7CwVM4guNBi8EJ+Mkx+OKhg eVGgJDwnX1oXVnEuaqYBINqHTIjh6+l1pK2hnI19APIAWSgTZRcxLWLE2AgA2133Pq vTPUmgGu/FQZQ1hasblfEQLSAnMNcy6STV+Q7zqY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Damien Le Moal , Niklas Cassel , Bart Van Assche , Jens Axboe , Sasha Levin Subject: [PATCH 6.1 101/102] null_blk: Do not allow runt zone with zone capacity smaller then zone size Date: Tue, 9 Jul 2024 13:11:04 +0200 Message-ID: <20240709110655.292944411@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240709110651.353707001@linuxfoundation.org> References: <20240709110651.353707001@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Damien Le Moal [ Upstream commit b164316808ec5de391c3e7b0148ec937d32d280d ] A zoned device with a smaller last zone together with a zone capacity smaller than the zone size does make any sense as that does not correspond to any possible setup for a real device: 1) For ZNS and zoned UFS devices, all zones are always the same size. 2) For SMR HDDs, all zones always have the same capacity. In other words, if we have a smaller last runt zone, then this zone capacity should always be equal to the zone size. Add a check in null_init_zoned_dev() to prevent a configuration to have both a smaller zone size and a zone capacity smaller than the zone size. Signed-off-by: Damien Le Moal Reviewed-by: Niklas Cassel Reviewed-by: Bart Van Assche Link: https://lore.kernel.org/r/20240530054035.491497-2-dlemoal@kernel.org Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/null_blk/zoned.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/block/null_blk/zoned.c b/drivers/block/null_blk/zoned.c index b0264b3df6f3d..206c2a7a5100e 100644 --- a/drivers/block/null_blk/zoned.c +++ b/drivers/block/null_blk/zoned.c @@ -83,6 +83,17 @@ int null_init_zoned_dev(struct nullb_device *dev, struct request_queue *q) return -EINVAL; } + /* + * If a smaller zone capacity was requested, do not allow a smaller last + * zone at the same time as such zone configuration does not correspond + * to any real zoned device. + */ + if (dev->zone_capacity != dev->zone_size && + dev->size & (dev->zone_size - 1)) { + pr_err("A smaller last zone is not allowed with zone capacity smaller than zone size.\n"); + return -EINVAL; + } + zone_capacity_sects = mb_to_sects(dev->zone_capacity); dev_capacity_sects = mb_to_sects(dev->size); dev->zone_size_sects = mb_to_sects(dev->zone_size); -- 2.43.0