From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3024A155A26; Tue, 9 Jul 2024 11:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720523927; cv=none; b=Uy/yQ7HxFkgryUn6KokgMDb469xGQ+biTgBaCfHl+bjLBfCwyxy4TvVqy/f1kBYiZUC2WRJQC2DQVz+vQNqSuG3U7YPwvPpHIxMai0uIWFQydnMKMh4yWgP34T3tfyFXp+9AUkKqDFuwRVsVfFwgIk2x0k64p7AEqu3kARECOok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720523927; c=relaxed/simple; bh=VpK5Ho2qPWGqLEI7g1qA0+GzEu4kBSljFkroJq5xT5Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WWpHGzC+oE50+P+2tQYL3yzXqoLKuQM7iTErt442BoISaA4+6RCou3HWs/o/AZKEkC7XkATtD6+h0a3H8FNGLmlVUVCKxcMc90V5KpK8x5ToXzOXmLkOJmOBK/bEbrGIKoCpiRz+G1OuyegP3yj6ErQS4RsuJUOcd/X93GcuZy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=05C3FfZQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="05C3FfZQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB4EFC3277B; Tue, 9 Jul 2024 11:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720523927; bh=VpK5Ho2qPWGqLEI7g1qA0+GzEu4kBSljFkroJq5xT5Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=05C3FfZQhMNlSoRB9MCz8CioQJg5zE3E7SkxG00sQ71U6u6zfrfs4Scit1pLG5aFd iDOaIqqDEQ4GHrNyE2dxmZxr+Pd9cJ/irObAn0ZwzVBgyPEYwRWOV8P32zW54sK0jT dwBBNywhxA5kQXWuMJICEFjfGowCeJd0QBmZstkI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guanrui Huang , Thomas Gleixner , Zenghui Yu , Marc Zyngier , Sasha Levin Subject: [PATCH 6.9 015/197] irqchip/gic-v3-its: Remove BUG_ON in its_vpe_irq_domain_alloc Date: Tue, 9 Jul 2024 13:07:49 +0200 Message-ID: <20240709110709.504762690@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240709110708.903245467@linuxfoundation.org> References: <20240709110708.903245467@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guanrui Huang [ Upstream commit 382d2ffe86efb1e2fa803d2cf17e5bfc34e574f3 ] This BUG_ON() is useless, because the same effect will be obtained by letting the code run its course and vm being dereferenced, triggering an exception. So just remove this check. Signed-off-by: Guanrui Huang Signed-off-by: Thomas Gleixner Reviewed-by: Zenghui Yu Acked-by: Marc Zyngier Link: https://lore.kernel.org/r/20240418061053.96803-3-guanrui.huang@linux.alibaba.com Signed-off-by: Sasha Levin --- drivers/irqchip/irq-gic-v3-its.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 6dbac6ec778ee..33fa6b7f41c93 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -4507,8 +4507,6 @@ static int its_vpe_irq_domain_alloc(struct irq_domain *domain, unsigned int virq struct page *vprop_page; int base, nr_ids, i, err = 0; - BUG_ON(!vm); - bitmap = its_lpi_alloc(roundup_pow_of_two(nr_irqs), &base, &nr_ids); if (!bitmap) return -ENOMEM; -- 2.43.0