From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 993701BE852; Tue, 9 Jul 2024 16:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720542160; cv=none; b=sAXuYKZHe/CH2PutCJ+gD7hrrXGWVfiV8KQYXADiNLB+tgJGbTOKgq4XUEzp+VeIq90ADymF+n/yZSK9gwxcArYF+PadQ1fg6Ec62zwysJp3GNL74vh6N4eiwUJ5ZJflm34azHqF4HShIhCyYVLZ3ogsUdu+/WTaZipBaiYXfSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720542160; c=relaxed/simple; bh=b4SomnNCTAmJuJpO2pOr6zCDjMQqojNPB6YfzbRoNxU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kCY5CKp5Quw86jJcmbGGRjWSBrxJ+bpFY8rI4MOYnIdudG/Y2jhPQM8cZK26SMd9/gYYgyCp2YDn40YCjohUo4VokB1ZA94JUg7ZhJRv1cGpSUl0E7tn1sarTloI4mw6r6hTiT+b86vt6igsaucIKXJDmzGFNhtNQIG87c7gMZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tLc4ekZX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tLc4ekZX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34BD1C3277B; Tue, 9 Jul 2024 16:22:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720542160; bh=b4SomnNCTAmJuJpO2pOr6zCDjMQqojNPB6YfzbRoNxU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tLc4ekZXS66nvc8i6YFFQ2XYQXaM+yA9jgU1B3yNttwDbKqAtmGL6ELp827UeZ/LW +GNGLC88W55zkgPB6rMYh0yRypuo2DdW+rsc0/QRLVTlI1wn1HB1Jy9RP8W6auFaBq ZDqWUVsTUhFnTi2M97aulGIaWnWcVeQlRO/bZtqvKHQt8sC48I583+gjMWR3QdAbBY 8PA5Ga3+U/3L6LLtOvc8/KkyWFATTpJPuBAxGP0ZWPfmC+VRpmdo8nY+EVjCH9OMWP x8/QhMwg4BTXIdH2sAMj5kgp/8VU/b8FAArXeBZ/oQEUnAqog4mFTKEi9157qlAbTx RY4TkIFt7yKhQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Amadeusz=20S=C5=82awi=C5=84ski?= , Cezary Rojewski , Mark Brown , Sasha Levin , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org Subject: [PATCH AUTOSEL 6.6 07/33] ASoC: topology: Clean up route loading Date: Tue, 9 Jul 2024 12:21:33 -0400 Message-ID: <20240709162224.31148-7-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240709162224.31148-1-sashal@kernel.org> References: <20240709162224.31148-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.38 Content-Transfer-Encoding: 8bit From: Amadeusz Sławiński [ Upstream commit e0e7bc2cbee93778c4ad7d9a792d425ffb5af6f7 ] Instead of using very long macro name, assign it to shorter variable and use it instead. While doing that, we can reduce multiple if checks using this define to one. Reviewed-by: Cezary Rojewski Signed-off-by: Amadeusz Sławiński Link: https://lore.kernel.org/r/20240603102818.36165-5-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/soc-topology.c | 26 ++++++++------------------ 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index 8b58a7864703e..e7a2426dd7443 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -1021,6 +1021,7 @@ static int soc_tplg_dapm_graph_elems_load(struct soc_tplg *tplg, struct snd_soc_tplg_hdr *hdr) { struct snd_soc_dapm_context *dapm = &tplg->comp->dapm; + const size_t maxlen = SNDRV_CTL_ELEM_ID_NAME_MAXLEN; struct snd_soc_tplg_dapm_graph_elem *elem; struct snd_soc_dapm_route *route; int count, i; @@ -1044,38 +1045,27 @@ static int soc_tplg_dapm_graph_elems_load(struct soc_tplg *tplg, tplg->pos += sizeof(struct snd_soc_tplg_dapm_graph_elem); /* validate routes */ - if (strnlen(elem->source, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) == - SNDRV_CTL_ELEM_ID_NAME_MAXLEN) { - ret = -EINVAL; - break; - } - if (strnlen(elem->sink, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) == - SNDRV_CTL_ELEM_ID_NAME_MAXLEN) { - ret = -EINVAL; - break; - } - if (strnlen(elem->control, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) == - SNDRV_CTL_ELEM_ID_NAME_MAXLEN) { + if ((strnlen(elem->source, maxlen) == maxlen) || + (strnlen(elem->sink, maxlen) == maxlen) || + (strnlen(elem->control, maxlen) == maxlen)) { ret = -EINVAL; break; } route->source = devm_kmemdup(tplg->dev, elem->source, - min(strlen(elem->source), - SNDRV_CTL_ELEM_ID_NAME_MAXLEN), + min(strlen(elem->source), maxlen), GFP_KERNEL); route->sink = devm_kmemdup(tplg->dev, elem->sink, - min(strlen(elem->sink), SNDRV_CTL_ELEM_ID_NAME_MAXLEN), + min(strlen(elem->sink), maxlen), GFP_KERNEL); if (!route->source || !route->sink) { ret = -ENOMEM; break; } - if (strnlen(elem->control, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) != 0) { + if (strnlen(elem->control, maxlen) != 0) { route->control = devm_kmemdup(tplg->dev, elem->control, - min(strlen(elem->control), - SNDRV_CTL_ELEM_ID_NAME_MAXLEN), + min(strlen(elem->control), maxlen), GFP_KERNEL); if (!route->control) { ret = -ENOMEM; -- 2.43.0