From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E30A17C9E9; Tue, 16 Jul 2024 15:45:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721144733; cv=none; b=u4j7uZJcYExY6CuAOsdD05R3LhjDPNQ1VK26p+3SatcOChypfHs+fB7/6sjhrYLArurxT1/VZ/VUsFocXYw1PCvapNiRVS7wlaXr5oGFFZOiuf2tDPbwIfPHt2o7f43vRHqF7FOYYehbyvaelsHr1Ez4TgUXCkbMzrwHGT4Vpw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721144733; c=relaxed/simple; bh=jFoMyGDg6NAPDOCbZGrL8PWMquZ1SLjmmRc+tWfycx0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t0zunxWJbcEPc5LQ+y5irJan/ZMuQQGPoHNFgLJ/5yNrrRIlr4owxVSoa9VPJnx+QzNMCzc2/YTVzm3uul4nJEe0/DWAHjg8GZ0DvZJvK5UDUZpqZmL8DJM/q7OSWqJ3Lykm9RSRc5vSgPZS8CWlcFZW/yCsxUyLdBU3dRcm5g4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TUFPojN5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TUFPojN5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8C13C4AF0D; Tue, 16 Jul 2024 15:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1721144733; bh=jFoMyGDg6NAPDOCbZGrL8PWMquZ1SLjmmRc+tWfycx0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TUFPojN50afpUM9cTUXLye4YETABCKOXaT0vJe2WJ/MP14sFOgqq3oNHgN+2kan4z nicbPAPPnk8OPbawNqNE8t5ymcD2JGo3eU0CoohriX3+0W6f3/3wYz2aKo5wWfc9eQ /Vp8qsWrroDcGNi2z6jDqjjOlyVghuV0zRKpj9Pw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joy Chakraborty , Dan Carpenter , Neil Armstrong , Srinivas Kandagatla Subject: [PATCH 5.10 087/108] nvmem: meson-efuse: Fix return value of nvmem callbacks Date: Tue, 16 Jul 2024 17:31:42 +0200 Message-ID: <20240716152749.325345604@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240716152745.988603303@linuxfoundation.org> References: <20240716152745.988603303@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Joy Chakraborty commit 7a0a6d0a7c805f9380381f4deedffdf87b93f408 upstream. Read/write callbacks registered with nvmem core expect 0 to be returned on success and a negative value to be returned on failure. meson_efuse_read() and meson_efuse_write() call into meson_sm_call_read() and meson_sm_call_write() respectively which return the number of bytes read or written on success as per their api description. Fix to return error if meson_sm_call_read()/meson_sm_call_write() returns an error else return 0. Fixes: a29a63bdaf6f ("nvmem: meson-efuse: simplify read callback") Cc: stable@vger.kernel.org Signed-off-by: Joy Chakraborty Reviewed-by: Dan Carpenter Reviewed-by: Neil Armstrong Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20240628113704.13742-3-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman --- drivers/nvmem/meson-efuse.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) --- a/drivers/nvmem/meson-efuse.c +++ b/drivers/nvmem/meson-efuse.c @@ -18,18 +18,24 @@ static int meson_efuse_read(void *contex void *val, size_t bytes) { struct meson_sm_firmware *fw = context; + int ret; - return meson_sm_call_read(fw, (u8 *)val, bytes, SM_EFUSE_READ, offset, - bytes, 0, 0, 0); + ret = meson_sm_call_read(fw, (u8 *)val, bytes, SM_EFUSE_READ, offset, + bytes, 0, 0, 0); + + return ret < 0 ? ret : 0; } static int meson_efuse_write(void *context, unsigned int offset, void *val, size_t bytes) { struct meson_sm_firmware *fw = context; + int ret; + + ret = meson_sm_call_write(fw, (u8 *)val, bytes, SM_EFUSE_WRITE, offset, + bytes, 0, 0, 0); - return meson_sm_call_write(fw, (u8 *)val, bytes, SM_EFUSE_WRITE, offset, - bytes, 0, 0, 0); + return ret < 0 ? ret : 0; } static const struct of_device_id meson_efuse_match[] = {