From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7245B1DDCE; Tue, 16 Jul 2024 16:00:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721145655; cv=none; b=evxBi5y4856iAp+U7Hz/cj6ZgOcdRa7pvoP1+T/IyzEUg8sTCJnIQ3FUwpX06SJTqUFxlAhfFtM2G9eaqtTHY76WRXgUC4ul/0R0Fi/If5aMOO8U89Fo9AeHceiqmwDR6PDv8G14xnUpiWgwdff4xUPwZ727q2a88o8KH78JO9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721145655; c=relaxed/simple; bh=L2Uv/cFnNsgJdTmvbo1RSadnUGYuSErbO0S2Zo9Syj8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WOZUtvchQ/1BtpGmzV1M6OtAwXmd2Y2ZHdkvIn819aRTQfJC2lgcYNR3Do3bH9A7mkHEyG4SXo4MR/Mvst98UInsaaJv1Be4zwtBvk2s+0LZ/OOVCn52MgdV3EdO2ibeznZMt0vlP7CeeLpFlJYLJI35ITXaQ1egAjnRZpzSzfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zV0fCeON; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zV0fCeON" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A9E9C116B1; Tue, 16 Jul 2024 16:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1721145655; bh=L2Uv/cFnNsgJdTmvbo1RSadnUGYuSErbO0S2Zo9Syj8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zV0fCeON15N9zZln3Lv2DxDZNIrPf7G1zd8W5cRpksHdLa0+hXgGFW9BBkwuQIOWG W2c38GV9yfDmAc8794kMCIQ+Z0LeUF8YPfQcw1N4kPAkEXs0jHjM+YvE6j2/Asx/fP wYtYUmJ2OnMjIpD9Hhrfl1OUUlsZL6TRwfwPGI0A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Aleksandr Mishin , Simon Horman , Paolo Abeni , Sasha Levin Subject: [PATCH 6.6 022/121] octeontx2-af: Fix incorrect value output on error path in rvu_check_rsrc_availability() Date: Tue, 16 Jul 2024 17:31:24 +0200 Message-ID: <20240716152752.176086310@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240716152751.312512071@linuxfoundation.org> References: <20240716152751.312512071@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aleksandr Mishin [ Upstream commit 442e26af9aa8115c96541026cbfeaaa76c85d178 ] In rvu_check_rsrc_availability() in case of invalid SSOW req, an incorrect data is printed to error log. 'req->sso' value is printed instead of 'req->ssow'. Looks like "copy-paste" mistake. Fix this mistake by replacing 'req->sso' with 'req->ssow'. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 746ea74241fa ("octeontx2-af: Add RVU block LF provisioning support") Signed-off-by: Aleksandr Mishin Reviewed-by: Simon Horman Link: https://patch.msgid.link/20240705095317.12640-1-amishin@t-argos.ru Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c index 32645aefd5934..5906f5f8d1904 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c @@ -1638,7 +1638,7 @@ static int rvu_check_rsrc_availability(struct rvu *rvu, if (req->ssow > block->lf.max) { dev_err(&rvu->pdev->dev, "Func 0x%x: Invalid SSOW req, %d > max %d\n", - pcifunc, req->sso, block->lf.max); + pcifunc, req->ssow, block->lf.max); return -EINVAL; } mappedlfs = rvu_get_rsrc_mapcount(pfvf, block->addr); -- 2.43.0