From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FF601586F6; Tue, 23 Jul 2024 18:26:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721759214; cv=none; b=HKqFsBE3m0WkEDQpyU6EzyS7/zlNoLubMHQXyZ8UtkwvVR4i5Ha+RspgJk65oYDCswnKSgAYxxp8KjCWyMKi0jss9G5WIj/b4BYRk+7WKQr/Wdd+7JEOyIzrMxhEn+gFikqcWQDYzvi0rzb7xWxHTAOmOsirZg1TF5O7Gi3adE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721759214; c=relaxed/simple; bh=P/gaEr8gX37TJAkm0tnBSi5xtthmyxROUiGfjZZmrkQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G1QIOpeNIshXDPtAzBzj5867V1LXdxK0bxoVevionxO9Fpc8oSeBQRvH2RUNIE+csAd0i8nzraifOq9ZJBIxKyr1zkZIq7VO1iQ5kzeDC9R3z0PBj1iqsrUVZdMCJOn4KcdeSOUQLQHjgFOx3ert2jI7+oYvnMIuqvxZMMtQJ5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=unET76vt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="unET76vt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2BB4C4AF0E; Tue, 23 Jul 2024 18:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1721759214; bh=P/gaEr8gX37TJAkm0tnBSi5xtthmyxROUiGfjZZmrkQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=unET76vt+q0FJdVa9AmfYR1Wxab46eON9xA4lKrzJYCZz891SFFlZRAywhXbp41cH eB0bsFn7jzgzm9eUHluBzg7iHt97bYl2mgBJVHCN/5gdCbnthoglxAH1IT1Hj8RwLB dQPYF0IfZTbv6J8CY7lqQaaEPQotcQIIrtcIL+l8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zizhi Wo , Baokun Li , Jeff Layton , Jia Zhu , Christian Brauner , Sasha Levin Subject: [PATCH 6.1 041/105] cachefiles: Set object to close if ondemand_id < 0 in copen Date: Tue, 23 Jul 2024 20:23:18 +0200 Message-ID: <20240723180404.827978796@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240723180402.490567226@linuxfoundation.org> References: <20240723180402.490567226@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zizhi Wo [ Upstream commit 4f8703fb3482f92edcfd31661857b16fec89c2c0 ] If copen is maliciously called in the user mode, it may delete the request corresponding to the random id. And the request may have not been read yet. Note that when the object is set to reopen, the open request will be done with the still reopen state in above case. As a result, the request corresponding to this object is always skipped in select_req function, so the read request is never completed and blocks other process. Fix this issue by simply set object to close if its id < 0 in copen. Signed-off-by: Zizhi Wo Signed-off-by: Baokun Li Link: https://lore.kernel.org/r/20240522114308.2402121-11-libaokun@huaweicloud.com Acked-by: Jeff Layton Reviewed-by: Jia Zhu Signed-off-by: Christian Brauner Signed-off-by: Sasha Levin --- fs/cachefiles/ondemand.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/cachefiles/ondemand.c b/fs/cachefiles/ondemand.c index c3241cede5289..37489ca2e8571 100644 --- a/fs/cachefiles/ondemand.c +++ b/fs/cachefiles/ondemand.c @@ -182,6 +182,7 @@ int cachefiles_ondemand_copen(struct cachefiles_cache *cache, char *args) xas_store(&xas, NULL); xa_unlock(&cache->reqs); + info = req->object->ondemand; /* fail OPEN request if copen format is invalid */ ret = kstrtol(psize, 0, &size); if (ret) { @@ -201,7 +202,6 @@ int cachefiles_ondemand_copen(struct cachefiles_cache *cache, char *args) goto out; } - info = req->object->ondemand; spin_lock(&info->lock); /* * The anonymous fd was closed before copen ? Fail the request. @@ -241,6 +241,11 @@ int cachefiles_ondemand_copen(struct cachefiles_cache *cache, char *args) wake_up_all(&cache->daemon_pollwq); out: + spin_lock(&info->lock); + /* Need to set object close to avoid reopen status continuing */ + if (info->ondemand_id == CACHEFILES_ONDEMAND_ID_CLOSED) + cachefiles_ondemand_set_object_close(req->object); + spin_unlock(&info->lock); complete(&req->done); return ret; } -- 2.43.0