From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: stable@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
patches@lists.linux.dev, Michael Ellerman <mpe@ellerman.id.au>,
Shuah Khan <skhan@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH 6.6 022/129] selftests: cachestat: Fix build warnings on ppc64
Date: Tue, 23 Jul 2024 20:22:50 +0200 [thread overview]
Message-ID: <20240723180405.647531815@linuxfoundation.org> (raw)
In-Reply-To: <20240723180404.759900207@linuxfoundation.org>
6.6-stable review patch. If anyone has any objections, please let me know.
------------------
From: Michael Ellerman <mpe@ellerman.id.au>
[ Upstream commit bc4d5f5d2debf8bb65fba188313481549ead8576 ]
Fix warnings like:
test_cachestat.c: In function ‘print_cachestat’:
test_cachestat.c:30:38: warning: format ‘%llu’ expects argument of
type ‘long long unsigned int’, but argument 2 has type ‘__u64’ {aka
‘long unsigned int’} [-Wformat=]
By switching to unsigned long long for u64 for ppc64 builds.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
tools/testing/selftests/cachestat/test_cachestat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c
index 4804c7dc7b312..ddb70d418c6a8 100644
--- a/tools/testing/selftests/cachestat/test_cachestat.c
+++ b/tools/testing/selftests/cachestat/test_cachestat.c
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
#define _GNU_SOURCE
+#define __SANE_USERSPACE_TYPES__ // Use ll64
#include <stdio.h>
#include <stdbool.h>
--
2.43.0
next prev parent reply other threads:[~2024-07-23 18:31 UTC|newest]
Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 18:22 [PATCH 6.6 000/129] 6.6.42-rc1 review Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 001/129] filelock: Remove locks reliably when fcntl/close race is detected Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 002/129] scsi: core: alua: I/O errors for ALUA state transitions Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 003/129] scsi: sr: Fix unintentional arithmetic wraparound Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 004/129] scsi: qedf: Dont process stag work during unload and recovery Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 005/129] scsi: qedf: Wait for stag work during unload Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 006/129] scsi: qedf: Set qed_slowpath_params to zero before use Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 007/129] efi/libstub: zboot.lds: Discard .discard sections Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 008/129] ACPI: EC: Abort address space access upon error Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 009/129] ACPI: EC: Avoid returning AE_OK on errors in address space handler Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 010/129] tools/power/cpupower: Fix Pstate frequency reporting on AMD Family 1Ah CPUs Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 011/129] wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 012/129] wifi: mac80211: apply mcast rate only if interface is up Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 013/129] wifi: mac80211: handle tasklet frames before stopping Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 014/129] wifi: cfg80211: fix 6 GHz scan request building Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 015/129] wifi: iwlwifi: mvm: d3: fix WoWLAN command version lookup Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 016/129] wifi: iwlwifi: mvm: remove stale STA link data during restart Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 017/129] wifi: iwlwifi: mvm: Handle BIGTK cipher in kek_kck cmd Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 018/129] wifi: iwlwifi: mvm: handle BA session teardown in RF-kill Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 019/129] wifi: iwlwifi: mvm: properly set 6 GHz channel direct probe option Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 020/129] wifi: iwlwifi: mvm: Fix scan abort handling with HW rfkill Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 021/129] wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan() Greg Kroah-Hartman
2024-07-23 18:22 ` Greg Kroah-Hartman [this message]
2024-07-23 18:22 ` [PATCH 6.6 023/129] selftests/openat2: Fix build warnings on ppc64 Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 024/129] selftests/futex: pass _GNU_SOURCE without a value to the compiler Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 025/129] of/irq: Factor out parsing of interrupt-map parent phandle+args from of_irq_parse_raw() Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 026/129] Input: silead - Always support 10 fingers Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 027/129] net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input() Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 028/129] ila: block BH in ila_output() Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 029/129] arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 030/129] null_blk: fix validation of block size Greg Kroah-Hartman
2024-07-23 18:22 ` [PATCH 6.6 031/129] kconfig: gconf: give a proper initial state to the Save button Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 032/129] kconfig: remove wrong expr_trans_bool() Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 033/129] input: Add event code for accessibility key Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 034/129] input: Add support for "Do Not Disturb" Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 035/129] HID: Ignore battery for ELAN touchscreens 2F2C and 4116 Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 036/129] NFSv4: Fix memory leak in nfs4_set_security_label Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 037/129] nfs: propagate readlink errors in nfs_symlink_filler Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 038/129] nfs: Avoid flushing many pages with NFS_FILE_SYNC Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 039/129] nfs: dont invalidate dentries on transient errors Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 040/129] cachefiles: add consistency check for copen/cread Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 041/129] cachefiles: Set object to close if ondemand_id < 0 in copen Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 042/129] cachefiles: make on-demand read killable Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 043/129] fs/file: fix the check in find_next_fd() Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 044/129] mei: demote client disconnect warning on suspend to debug Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 045/129] iomap: Fix iomap_adjust_read_range for plen calculation Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 046/129] drm/exynos: dp: drop driver owner initialization Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 047/129] drm: panel-orientation-quirks: Add quirk for Aya Neo KUN Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 048/129] drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 049/129] nvme: avoid double free special payload Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 050/129] nvmet: always initialize cqe.result Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 051/129] ALSA: hda: cs35l56: Fix lifecycle of codec pointer Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 052/129] wifi: cfg80211: wext: add extra SIOCSIWSCAN data check Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 053/129] ALSA: hda/realtek: Support Lenovo Thinkbook 16P Gen 5 Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 054/129] KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group() Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 055/129] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 056/129] ALSA: hda/realtek: Add more codec ID to no shutup pins list Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 057/129] spi: Fix OCTAL mode support Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 058/129] cpumask: limit FORCE_NR_CPUS to just the UP case Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 059/129] selftests: openvswitch: Set value to nla flags Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 060/129] drm/amdgpu: Indicate CU havest info to CP Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 061/129] ALSA: hda: cs35l56: Select SERIAL_MULTI_INSTANTIATE Greg Kroah-Hartman
2024-07-24 9:36 ` Simon Trimmer
2024-07-24 13:48 ` 'Greg Kroah-Hartman'
2024-07-24 15:57 ` Simon Trimmer
2024-07-23 18:23 ` [PATCH 6.6 062/129] mips: fix compat_sys_lseek syscall Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 063/129] Input: elantech - fix touchpad state on resume for Lenovo N24 Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 064/129] Input: i8042 - add Ayaneo Kun to i8042 quirk table Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 065/129] ASoC: rt722-sdca-sdw: add silence detection register as volatile Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 066/129] Input: xpad - add support for ASUS ROG RAIKIRI PRO Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 067/129] ASoC: topology: Fix references to freed memory Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 068/129] ASoC: topology: Do not assign fields that are already set Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 069/129] bytcr_rt5640 : inverse jack detect for Archos 101 cesium Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 070/129] ALSA: dmaengine: Synchronize dma channel after drop() Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 071/129] ASoC: ti: davinci-mcasp: Set min period size using FIFO config Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 072/129] ASoC: ti: omap-hdmi: Fix too long driver name Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 073/129] ASoC: SOF: sof-audio: Skip unprepare for in-use widgets on error rollback Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 074/129] ASoC: rt722-sdca-sdw: add debounce time for type detection Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 075/129] nvme: fix NVME_NS_DEAC may incorrectly identifying the disk as EXT_LBA Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 076/129] Input: ads7846 - use spi_device_id table Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 077/129] can: kvaser_usb: fix return value for hif_usb_send_regout Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 078/129] gpio: pca953x: fix pca953x_irq_bus_sync_unlock race Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 079/129] octeontx2-pf: Fix coverity and klockwork issues in octeon PF driver Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 080/129] s390/sclp: Fix sclp_init() cleanup on failure Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 081/129] platform/mellanox: nvsw-sn2201: Add check for platform_device_add_resources Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 082/129] platform/x86: wireless-hotkey: Add support for LG Airplane Button Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 083/129] platform/x86: lg-laptop: Remove LGEX0815 hotkey handling Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 084/129] platform/x86: lg-laptop: Change ACPI device id Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 085/129] platform/x86: lg-laptop: Use ACPI device handle when evaluating WMAB/WMBB Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 086/129] btrfs: qgroup: fix quota root leak after quota disable failure Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 087/129] ibmvnic: Add tx check to prevent skb leak Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 088/129] ALSA: PCM: Allow resume only for suspended streams Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 089/129] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 090/129] ALSA: dmaengine_pcm: terminate dmaengine before synchronize Greg Kroah-Hartman
2024-07-23 18:23 ` [PATCH 6.6 091/129] ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 092/129] net: usb: qmi_wwan: add Telit FN912 compositions Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 093/129] net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 094/129] powerpc/pseries: Whitelist dtl slub object for copying to userspace Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 095/129] powerpc/eeh: avoid possible crash when edev->pdev changes Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 096/129] scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 097/129] tee: optee: ffa: Fix missing-field-initializers warning Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 098/129] Bluetooth: hci_core: cancel all works upon hci_unregister_dev() Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 099/129] Bluetooth: btnxpuart: Enable Power Save feature on startup Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 100/129] bluetooth/l2cap: sync sock recv cb and release Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 101/129] erofs: ensure m_llen is reset to 0 if metadata is invalid Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 102/129] drm/amd/display: Add refresh rate range check Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 103/129] drm/amd/display: Account for cursor prefetch BW in DML1 mode support Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 104/129] drm/amd/display: Fix refresh rate range for some panel Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 105/129] drm/radeon: check bo_va->bo is non-NULL before using it Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 106/129] fs: better handle deep ancestor chains in is_subdir() Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 107/129] wifi: iwlwifi: properly set WIPHY_FLAG_SUPPORTS_EXT_KEK_KCK Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 108/129] drivers/perf: riscv: Reset the counter to hpmevent mapping while starting cpus Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 109/129] riscv: stacktrace: fix usage of ftrace_graph_ret_addr() Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 110/129] spi: imx: Dont expect DMA for i.MX{25,35,50,51,53} cspi devices Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 111/129] ksmbd: return FILE_DEVICE_DISK instead of super magic Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 112/129] ASoC: SOF: Intel: hda-pcm: Limit the maximum number of periods by MAX_BDL_ENTRIES Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 113/129] selftest/timerns: fix clang build failures for abs() calls Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 114/129] selftests/vDSO: fix clang build errors and warnings Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 115/129] hfsplus: fix uninit-value in copy_name Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 116/129] selftests/bpf: Extend tcx tests to cover late tcx_entry release Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 117/129] spi: mux: set ctlr->bits_per_word_mask Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 118/129] ALSA: hda: Use imply for suggesting CONFIG_SERIAL_MULTI_INSTANTIATE Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 119/129] cifs: fix noisy message on copy_file_range Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 120/129] ARM: 9324/1: fix get_user() broken with veneer Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 121/129] mm: page_ref: remove folio_try_get_rcu() Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 122/129] Bluetooth: L2CAP: Fix deadlock Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 123/129] of/irq: Disable "interrupt-map" parsing for PASEMI Nemo Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 124/129] wifi: cfg80211: wext: set ssids=NULL for passive scans Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 125/129] wifi: mac80211: disable softirqs for queued frame handling Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 126/129] wifi: iwlwifi: mvm: dont wake up rx_sync_waitq upon RFKILL Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 127/129] netfs, fscache: export fscache_put_volume() and add fscache_try_get_volume() Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 128/129] cachefiles: fix slab-use-after-free in fscache_withdraw_volume() Greg Kroah-Hartman
2024-07-23 18:24 ` [PATCH 6.6 129/129] cachefiles: fix slab-use-after-free in cachefiles_withdraw_cookie() Greg Kroah-Hartman
2024-07-23 20:55 ` [PATCH 6.6 000/129] 6.6.42-rc1 review Florian Fainelli
2024-07-24 7:35 ` Jon Hunter
2024-07-24 8:34 ` Harshit Mogalapalli
2024-07-24 11:10 ` Conor Dooley
2024-07-24 11:16 ` Mark Brown
2024-07-24 12:25 ` Takeshi Ogasawara
2024-07-24 13:12 ` Peter Schneider
2024-07-24 13:58 ` Shreeya Patel
2024-07-24 15:20 ` Shuah Khan
2024-07-24 17:51 ` Naresh Kamboju
2024-07-25 5:24 ` Ron Economos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240723180405.647531815@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=mpe@ellerman.id.au \
--cc=patches@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).