From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ECD242067; Tue, 23 Jul 2024 18:33:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721759584; cv=none; b=KBNWAwYX8F3XozOFqxJTVgLCTtkUfwd2u5Hq04PvtCAUvpBSnTD2Qb5FGmnINYIrFZZ0dkwiKxlhAZVKpldOB71OwVYciyc4o9XeEj/FDvbrkBReKvMPKdFec01pfFP79CJkTUDRTHnV7sucqtpHFtTxFLifYBcggld4ij7lKLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721759584; c=relaxed/simple; bh=F8SSD433S/nShTLDfCxy9bBVlMLqjWUyDsqD1jxOel8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oDee78N2x/535WDJftf1flId9BgykEEWHsh5u6DkLONS7LaEryBNkkQJ0DlTVBNrKFyr3Hgai7wrRRfjrpESYCCOKk4c8JcnvDqUhgihZqoZejC8nOhgHKpgtn/TXIHU3k62+VXtOAkvMB1QoGyJ+mNru7FtubTGa6y/REOpbng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jAH20u53; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jAH20u53" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8E96C4AF09; Tue, 23 Jul 2024 18:33:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1721759584; bh=F8SSD433S/nShTLDfCxy9bBVlMLqjWUyDsqD1jxOel8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jAH20u53LWOILlLHM5DdfYZbGeEZqhREbNMX3WD5VaRHe+VA2x5LJMkXJQ+o6xbr4 bMUt8rC1uLwQHyhwVa2VDl6lxD2Wi7+x5LZJaNmKXb03GLuq/SHgSHbViMKCV/cf61 fiUVb0dcct5VhwGKf6NhixmyPu9IZZhbMTMICyjk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wei Li , Huisong Li , Will Deacon , Sasha Levin Subject: [PATCH 6.6 029/129] arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Date: Tue, 23 Jul 2024 20:22:57 +0200 Message-ID: <20240723180405.916432459@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240723180404.759900207@linuxfoundation.org> References: <20240723180404.759900207@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wei Li [ Upstream commit 14951beaec93696b092a906baa0f29322cf34004 ] The function run_all_insn_set_hw_mode() is registered as startup callback of 'CPUHP_AP_ARM64_ISNDEP_STARTING', it invokes set_hw_mode() methods of all emulated instructions. As the STARTING callbacks are not expected to fail, if one of the set_hw_mode() fails, e.g. due to el0 mixed-endian is not supported for 'setend', it will report a warning: ``` CPU[2] cannot support the emulation of setend CPU 2 UP state arm64/isndep:starting (136) failed (-22) CPU2: Booted secondary processor 0x0000000002 [0x414fd0c1] ``` To fix it, add a check for INSN_UNAVAILABLE status and skip the process. Signed-off-by: Wei Li Tested-by: Huisong Li Link: https://lore.kernel.org/r/20240423093501.3460764-1-liwei391@huawei.com Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- arch/arm64/kernel/armv8_deprecated.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c index e459cfd337117..d6b711e56df97 100644 --- a/arch/arm64/kernel/armv8_deprecated.c +++ b/arch/arm64/kernel/armv8_deprecated.c @@ -464,6 +464,9 @@ static int run_all_insn_set_hw_mode(unsigned int cpu) for (int i = 0; i < ARRAY_SIZE(insn_emulations); i++) { struct insn_emulation *insn = insn_emulations[i]; bool enable = READ_ONCE(insn->current_mode) == INSN_HW; + if (insn->status == INSN_UNAVAILABLE) + continue; + if (insn->set_hw_mode && insn->set_hw_mode(enable)) { pr_warn("CPU[%u] cannot support the emulation of %s", cpu, insn->name); -- 2.43.0