From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 895E219AA5F; Thu, 25 Jul 2024 14:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721918489; cv=none; b=n87VjBZSc/9ifQEiZXK7MH+TZSZtN77g2oJZ+KjkFeAKlck1SekWY3mz0v6NUvjveV3IbHUTN88xlO/AzwnnlYCkSluZLjMq5Wb/K7sqt9MLau1N7otzzi5nYjr8OUy0oztSnWcK+ymH2Gc9TxRlxfa/nPwbMxgYV8mYzB6QbLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721918489; c=relaxed/simple; bh=/x/48g2TsdmPwd7NEnVz8eFobsrW4l5Gcg4Zkg8Gq4w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cHcVfGMI3kiFldYlW+Z3NSAM9fS7Wfl5LxY2OrV3wfwVS/Akm96DaPLJ5/sf/8WKqBe+aR0b9x0O6E5iaQnBCjab2DyuhGMw1+/w060Jkozk+/7Vm+MBMNd2N9pwg3u+PCBixaTWUsyPpdW0hi5aLPxSX0JArLWyb9w1W5uL6X4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0TucTU+U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0TucTU+U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BF88C116B1; Thu, 25 Jul 2024 14:41:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1721918489; bh=/x/48g2TsdmPwd7NEnVz8eFobsrW4l5Gcg4Zkg8Gq4w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0TucTU+UiucmdhBDmR6mZGXZAiheAb8O/j8dYP8NFE/erDuxfjOC8EYgnYfgM8yoG 6H2LJWAemCSKaG8LdLijVcilBeRiXh51ZMBpgYPbVUzk0OTYGvnjOK9U2WQcLdRbx5 n9V9Nug2itcN4KPyRDQb5+H86Zs6UpgRA9VHcZA4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nicolas Escande , Johannes Berg , Sasha Levin Subject: [PATCH 4.19 05/33] wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata Date: Thu, 25 Jul 2024 16:36:28 +0200 Message-ID: <20240725142728.721654222@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240725142728.511303502@linuxfoundation.org> References: <20240725142728.511303502@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nicolas Escande [ Upstream commit 6f6291f09a322c1c1578badac8072d049363f4e6 ] With a ath9k device I can see that: iw phy phy0 interface add mesh0 type mp ip link set mesh0 up iw dev mesh0 scan Will start a scan with the Power Management bit set in the Frame Control Field. This is because we set this bit depending on the nonpeer_pm variable of the mesh iface sdata and when there are no active links on the interface it remains to NL80211_MESH_POWER_UNKNOWN. As soon as links starts to be established, it wil switch to NL80211_MESH_POWER_ACTIVE as it is the value set by befault on the per sta nonpeer_pm field. As we want no power save by default, (as expressed with the per sta ini values), lets init it to the expected default value of NL80211_MESH_POWER_ACTIVE. Also please note that we cannot change the default value from userspace prior to establishing a link as using NL80211_CMD_SET_MESH_CONFIG will not work before NL80211_CMD_JOIN_MESH has been issued. So too late for our initial scan. Signed-off-by: Nicolas Escande Link: https://msgid.link/20240527141759.299411-1-nico.escande@gmail.com Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/mac80211/mesh.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c index 3162f955f3ae2..c9a5271d9b59d 100644 --- a/net/mac80211/mesh.c +++ b/net/mac80211/mesh.c @@ -1454,6 +1454,7 @@ void ieee80211_mesh_init_sdata(struct ieee80211_sub_if_data *sdata) ifmsh->last_preq = jiffies; ifmsh->next_perr = jiffies; ifmsh->csa_role = IEEE80211_MESH_CSA_ROLE_NONE; + ifmsh->nonpeer_pm = NL80211_MESH_POWER_ACTIVE; /* Allocate all mesh structures when creating the first mesh interface. */ if (!mesh_allocated) ieee80211s_init(); -- 2.43.0